Syntax changes for recursive pattern-matching feature #32432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
the
PR For Personal Review Only
jcouv
reviewed
Jan 14, 2019
src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Jan 14, 2019
jcouv
reviewed
Jan 14, 2019
jcouv
reviewed
Jan 14, 2019
|
Sorry, I failed to notice the "personal" label. #Closed |
- Permit a trailing comma after the last arm of a switch expression - Permit a trailing comma after the last subpattern of a property pattern clause Fixes dotnet#32292
gafter
force-pushed
the
rpatterns-32291
branch
from
abde91d to
788b90b
Compare
gafter
removed
the
PR For Personal Review Only
|
@dotnet/roslyn-compiler May I please have a couple of reviews of this set of syntax changes for pattern-matching? It is targeting P3. |
cston
approved these changes
Jan 17, 2019
This was referenced Jan 18, 2019
xoofx
pushed a commit
to stark-lang/stark-roslyn
that referenced
this pull request
Apr 16, 2019
* Rename "deconstruct pattern" to "positional pattern" in the APIs. Fixes dotnet#32291 * Permit a trailing commas in two places - Permit a trailing comma after the last arm of a switch expression - Permit a trailing comma after the last subpattern of a property pattern clause Fixes dotnet#32292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "deconstruct pattern" to "positional pattern" in the APIs.
Fixes #32291
Permit a trailing commas in two places
Fixes #32292