Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE1006 should not warn when name is all underscores #40713

Closed
JohanLarsson opened this issue Jan 3, 2020 · 1 comment · Fixed by #68086
Closed

IDE1006 should not warn when name is all underscores #40713

JohanLarsson opened this issue Jan 3, 2020 · 1 comment · Fixed by #68086
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug Feature - IDE1006 Naming styles help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Backlog

Comments

@JohanLarsson
Copy link

JohanLarsson commented Jan 3, 2020 •
edited
Loading 

void M()
{
    //                            ↓ IDE1006 should not warn here
    Console.CancelKeyPress += (_, __) => { };
}
@JohanLarsson JohanLarsson changed the title IDE1016 should not warn when name is all underscores IDE1006 should not warn when name is all underscores Jan 3, 2020
@jinujoseph jinujoseph added the Bug label Jan 8, 2020
@jinujoseph jinujoseph added this to the 16.5 milestone Jan 8, 2020
@jinujoseph jinujoseph added the Need Design Review The end user experience design needs to be reviewed and approved. label Jan 8, 2020
@mavasani mavasani modified the milestones: 16.5, Backlog Jan 14, 2020
@sharwell sharwell added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed Need Design Review The end user experience design needs to be reviewed and approved. labels Feb 3, 2020
@mavasani mavasani removed their assignment Feb 3, 2020
@mavasani
Copy link
Contributor

mavasani commented Feb 3, 2020

Design meeting review:
We will accept a PR to implement the requested behavior.

@CyrusNajmabadi CyrusNajmabadi added the Feature - IDE1006 Naming styles label Nov 1, 2022
Sjoerdsjoerd added a commit to Sjoerdsjoerd/roslyn that referenced this issue May 4, 2023
@Sjoerdsjoerd
Implemented dotnet#40713
dd69b7b
@sharwell sharwell mentioned this issue May 4, 2023
Merged
@sharwell sharwell added the 4 - In Review A fix for the issue is submitted for review. label May 4, 2023
CyrusNajmabadi pushed a commit that referenced this issue May 10, 2023
@Sjoerdsjoerd
IDE1006: Support multiple underscores (#68086)
7bf85c9 
* Implemented #40713

* Added testcases
@sharwell sharwell moved this to Complete in IDE: Design review Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug Feature - IDE1006 Naming styles help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
IDE: Design review
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

IDE1006: Support multiple underscores Sjoerdsjoerd/roslyn
6 participants
@jaredpar @sharwell @JohanLarsson @CyrusNajmabadi @mavasani @jinujoseph