IDE1006: Support multiple underscores

[Sjoerdsjoerd]

The issue describes the problem when multiple underscores are used, and the IDE still gives the IDE1006 message.

In a quick glance I could not find any unit tests for IDE1006, so I tested it locally and it seems to work.

Closes #40713

[sharwell]

Tests can be added to these files:

https://github.com/dotnet/roslyn/blob/main/src/Analyzers/CSharp/Tests/NamingStyles/NamingStylesTests.cs
https://github.com/dotnet/roslyn/blob/main/src/Analyzers/VisualBasic/Tests/NamingStyles/NamingStylesTests.vb

[Youssef1313]

Best to have another PR to dotnet/roslyn-analyzers as well:

https://github.com/dotnet/roslyn-analyzers/blob/main/src/Utilities/Compiler/Extensions/ISymbolExtensions.cs

[Sjoerdsjoerd]

Tests can be added to these files:

https://github.com/dotnet/roslyn/blob/main/src/Analyzers/CSharp/Tests/NamingStyles/NamingStylesTests.cs https://github.com/dotnet/roslyn/blob/main/src/Analyzers/VisualBasic/Tests/NamingStyles/NamingStylesTests.vb

I have extended the discard tests with the extra underscores

[Sjoerdsjoerd]

Best to have another PR to dotnet/roslyn-analyzers as well:

https://github.com/dotnet/roslyn-analyzers/blob/main/src/Utilities/Compiler/Extensions/ISymbolExtensions.cs

Sure, I will create an PR there as well.

[sharwell]

This appears to meet the behavior described in the original issue, but leaving the final review to @mavasani to confirm there haven't been any changes to the space over the past 3 years.

[mavasani]

This appears to meet the behavior described in the original issue, but leaving the final review to @mavasani to confirm there haven't been any changes to the space over the past 3 years.

I can’t recall any subsequent design discussions on this, so seems fine to me.

[Sjoerdsjoerd]

The pipeline is failing. Is it possible to restart it?

[CyrusNajmabadi]

Thanks!