Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures: Microsoft.CodeAnalysis.CompilerServer.UnitTests.NamedPipeClientConnectionHostTests.EndListenClosesQueuedConnections #47231

Closed
runfoapp bot opened this issue Aug 28, 2020 · 3 comments · Fixed by #47246
Closed

Test failures: Microsoft.CodeAnalysis.CompilerServer.UnitTests.NamedPipeClientConnectionHostTests.EndListenClosesQueuedConnections #47231

runfoapp bot opened this issue Aug 28, 2020 · 3 comments · Fixed by #47246
Assignees
@jaredpar
Labels
Area-Compilers Bug
Milestone
16.8

Comments

@runfoapp
Copy link

runfoapp bot commented Aug 28, 2020 •
edited by jaredpar
Loading

Build Kind Run Name
791688 PR 47148 Windows Desktop Spanish
791605 Rolling Windows Desktop Spanish
791582 Rolling Windows Desktop Spanish
790557 PR 45599 Windows Desktop Release Test64
790443 PR 47192 Windows CoreClr Release
790439 PR 47165 Windows Desktop Spanish
790415 PR 46826 Windows Desktop Debug Test64
789574 PR 46949 Windows Desktop Spanish
789574 PR 46949 Windows Desktop Spanish

Runfo Query
@jaredpar jaredpar self-assigned this Aug 28, 2020
@jaredpar
Copy link
Member

Looks like this is hitting a null ref during the test.

@jaredpar jaredpar added this to the 16.8 milestone Aug 28, 2020
@Youssef1313 Youssef1313 mentioned this issue Aug 28, 2020
Closed
@sharwell
Copy link
Member

@jaredpar it would be nice if we had a column for target branch, and commit hash which was head of target branch at the time of the build.

@jaredpar jaredpar mentioned this issue Aug 28, 2020
Open
@jaredpar
Copy link
Member

That is fairly easy to add. Tracking here jaredpar/runfo#16

@sharwell sharwell mentioned this issue Aug 28, 2020
Open
jaredpar added a commit to jaredpar/roslyn that referenced this issue Aug 28, 2020
@jaredpar
Fix flaky compiler server test.
bf3b183 
The test was using a timeout when connecting to the server. This was
likely leading to the connect failing during a load situation. Removed
the timeout and added a proper `Assert.NotNull` check to catch the issue
if this doesn't truly fix it.

closes dotnet#47231
@jaredpar jaredpar mentioned this issue Aug 28, 2020
Merged
This was referenced Aug 28, 2020
Closed
Closed
jaredpar added a commit that referenced this issue Sep 1, 2020
@jaredpar
Fix flaky compiler server test. (#47246)
f530730 
* Fix flaky compiler server test.

The test was using a timeout when connecting to the server. This was
likely leading to the connect failing during a load situation. Removed
the timeout and added a proper `Assert.NotNull` check to catch the issue
if this doesn't truly fix it.

closes #47231

* Fix warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredpar jaredpar

Labels
Area-Compilers Bug
Projects
None yet
Milestone
16.8
Development

Successfully merging a pull request may close this issue.

Fix flaky compiler server test. jaredpar/roslyn
2 participants
@jaredpar @sharwell