Remove IActiveStatementSpanTracker #46826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Aug 14, 2020
sharwell
commented
Aug 14, 2020
src/EditorFeatures/Test/EditAndContinue/EditAndContinueWorkspaceServiceTests.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Aug 14, 2020
src/Features/CSharp/Portable/EditAndContinue/CSharpEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Aug 14, 2020
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Aug 14, 2020
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Aug 14, 2020
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Aug 14, 2020
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
force-pushed
the
rm-spans
branch
3 times, most recently
from
64a3d45
to
677e86f
Compare
tmat
approved these changes
Aug 27, 2020
ghost
added this to the
This was referenced Aug 28, 2020
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 28, 2020
* upstream/master: (220 commits) Don't load generators that target net framework explicitly. (dotnet#47100) Update src/Features/Core/Portable/UnifiedSuggestions/UnifiedSuggestedActionsSource.cs Clean up redundant code action filtering Remove IActiveStatementSpanTracker (dotnet#46826) Disable API analysis if telemetry is disabled Update src/Workspaces/Remote/ServiceHub/Services/CodeAnalysis/CodeAnalysisService_SemanticClassificationCache.cs Doc Compress two values. PR feedback Revert Revert Lint Fix formatting Fire and forget Fix mangling Ensure that local functions are also marked as invalid if their containing methods are generic. Fix dependency graph for AnalyzerRunner Add AnalyzerRunner target for net5.0 Make VerifyForwardedTypes asynchronous Fix bug when "End statement" is used in single-line if (dotnet#47062) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a workspace service to retrieve the spans the EnC analyzer now takes a snapshot of the spans along with the corresponding document snapshot. Methods on EditAndContinueWorkspaceService are updated to take a callback that retrieves the spans for a given document on demand. This callback is called just before the service queries the EnC analyzer for an analysis of a document but at the same time during the EditAndContinueWorkspaceService method call that passed in the callback. This is important because in future PR each method of the service will be a remote call to OOP and the solution snapshot this method operates on is only going to be available to the OOP within the method call.