Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAllHostStateSets allocates large amounts of data when loading giant solutions #54400

Closed
sharwell opened this issue Jun 25, 2021 · 0 comments · Fixed by #54401
Closed

GetAllHostStateSets allocates large amounts of data when loading giant solutions #54400

sharwell opened this issue Jun 25, 2021 · 0 comments · Fixed by #54401
Labels
Area-IDE Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented

Comments

@sharwell
Copy link
Member

Originally observed by @davkean in review of traces loading a solution with 900+ projects.

image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 25, 2021
@sharwell sharwell mentioned this issue Jun 25, 2021
Merged
sharwell added a commit to sharwell/roslyn that referenced this issue Jun 25, 2021
@sharwell
Avoid costly calls to GetAllStateSets inside ContainsDiagnostics
ee53ed3 
Fixes dotnet#54400
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐇 Avoid costly calls to GetAllStateSets inside ContainsDiagnostics sharwell/roslyn
1 participant
@sharwell