🐇 Avoid costly calls to GetAllStateSets inside ContainsDiagnostics #54401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs
Show resolved
Hide resolved
sharwell
force-pushed
the
faster-state-sets
branch
from
0a589a5
to
ee53ed3
Compare
drewnoakes
reviewed
Jun 26, 2021
Comment on lines
+69
to
+70
| return _stateManager.HasAnyHostStateSet(static (stateSet, arg) => stateSet.ContainsAnyDocumentOrProjectDiagnostics(arg), projectId) | ||
| || _stateManager.HasAnyProjectStateSet(projectId, static (stateSet, arg) => stateSet.ContainsAnyDocumentOrProjectDiagnostics(arg), projectId); |
There was a problem hiding this comment.
Is this the best order for these tests? I'm not familiar with the contents of the data collections here, but HasAnyProjectStateSet has only one level of looping, while HasAnyHostStateSet has two.
There was a problem hiding this comment.
I'm not certain which order is best, but I believe the current order matches what the prior implementation used. For the expected/target case, this method would return false, implying both paths are used.
sharwell
changed the title
CyrusNajmabadi
approved these changes
Jun 29, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54400