Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'dotnet/master' into DefaultInterfaceImplementation #19648

Merged
Changes from 1 commit
Commits
Show all changes
391 commits
Select commit Hold shift + click to select a range
5e053aa
remove _showPosition (#19353)
TyOverby May 10, 2017
eddbafc
Addressed pr feedback, export parts as shared and in the correct layer.
333fred May 10, 2017
b5c01a4
Added post-suggestion listener
333fred May 9, 2017
a404917
Merge pull request #19374 from CyrusNajmabadi/serializationSimplifica…
CyrusNajmabadi May 10, 2017
f61d8c4
Merge remote-tracking branch 'upstream/master' into useThrowExtraStat…
CyrusNajmabadi May 10, 2017
a4dbea3
Use file path to hook up analyzers nodes in Solution Explorer
tmeschter May 10, 2017
4a1b805
Simplify check.
CyrusNajmabadi May 10, 2017
ab924b3
Merge pull request #19366 from 333fred/info-bar-refactor
333fred May 10, 2017
7c50394
Migrate BasicEditAndContinue integration tests from Tao to .NET (#19381)
ivanbasov May 10, 2017
2223e15
Merge pull request #19396 from mavasani/FixBuildBreak
mavasani May 10, 2017
6a3f934
added more comments
heejaechang May 10, 2017
11f3f8a
add assert
heejaechang May 10, 2017
71a9fc8
fixed merge conflicts
heejaechang May 10, 2017
934fbe9
Createing indices for metadata can fail. Be resilient to that.
CyrusNajmabadi May 10, 2017
737d993
Store a copy of the checksum as we may have failed to create an index…
CyrusNajmabadi May 10, 2017
174035e
fix build break.
heejaechang May 10, 2017
a785172
Take an approach where we cannot get Null Symbol Tree infos.
CyrusNajmabadi May 10, 2017
c10565e
Fix grammar.
CyrusNajmabadi May 10, 2017
9862f36
Share code.
CyrusNajmabadi May 10, 2017
b4c9c9e
Add more contract guarantees
CyrusNajmabadi May 10, 2017
8b7ad83
Don't require spell checker.
CyrusNajmabadi May 10, 2017
c0adc62
Simplify code.
CyrusNajmabadi May 10, 2017
e01e55a
Merge branch 'master' into features/async-main
TyOverby May 10, 2017
51de32f
Rename parameter.
CyrusNajmabadi May 10, 2017
4ddfe1f
Fix comparison.
CyrusNajmabadi May 10, 2017
71c8e3e
Cache the delegates we use in simplification.
CyrusNajmabadi May 11, 2017
8e4e29b
Pool the simplifiers we create while simplifying code.
CyrusNajmabadi May 11, 2017
be8d91b
Fix null ref.
CyrusNajmabadi May 11, 2017
ea768e0
Fix null ref.
CyrusNajmabadi May 11, 2017
9094189
Merge branch 'cacheDelegates' into poolSimplifiers
CyrusNajmabadi May 11, 2017
db8ed0f
Revert change.
CyrusNajmabadi May 11, 2017
451641b
Respect user settings around 'Blocks' when adding parameter null checks.
CyrusNajmabadi May 11, 2017
841044b
Share pattern-matching temps when they are the same type. (#19378)
gafter May 11, 2017
5b08615
setting default VB options
jmarolf May 10, 2017
1c66e33
setting option strict to on
jmarolf May 10, 2017
3527fbb
removing no warn for type conversions
jmarolf May 10, 2017
b0249ee
Remove remaining prototype comments (#19392)
TyOverby May 11, 2017
a34367f
Merge branch 'master' into features/async-main
TyOverby May 11, 2017
7a7210d
Merge branch 'features/async-main' of github.com:dotnet/roslyn into f…
TyOverby May 11, 2017
8b6e74a
Merge pull request #19264 from alrz/bug-19225
Pilchie May 11, 2017
fa407a6
Merge pull request #19424 from CyrusNajmabadi/poolSimplifiers
CyrusNajmabadi May 11, 2017
8b18ed2
Merge remote-tracking branch 'upstream/master' into blockSimplification
CyrusNajmabadi May 11, 2017
bedaa5e
Merge pull request #19379 from CyrusNajmabadi/useThrowExtraStatemnets
CyrusNajmabadi May 11, 2017
4599499
Added initial user filtering
333fred May 11, 2017
2458ada
Regression test for #19434 which appear to be fixed.
VSadov May 11, 2017
0974be1
Merge remote-tracking branch 'upstream/master' into nullMetadataInfo
CyrusNajmabadi May 11, 2017
baa7ebd
Merge remote-tracking branch 'upstream/master' into blockSimplification
CyrusNajmabadi May 11, 2017
fdc02b9
Add simplification tests.
CyrusNajmabadi May 11, 2017
c757297
Extract out the ExtractAnalyzerFilePath method
tmeschter May 11, 2017
ca449a6
Disabling flakey tests covered by #19441 (#19442)
ivanbasov May 11, 2017
0d01ae9
Be resilient to null-paths/names for Documents/Projects in SqlitePers…
CyrusNajmabadi May 11, 2017
f125368
Add tests.
CyrusNajmabadi May 11, 2017
f1979f7
Add comments.
CyrusNajmabadi May 11, 2017
d15e1a6
Merge pull request #19436 from dotnet/features/async-main
TyOverby May 11, 2017
776045a
Added in check for VSIX installation. Moved all checks to background …
333fred May 11, 2017
89ad231
Refout: Re-enable NoPia, add tests from feature review (#19416)
jcouv May 11, 2017
7a208ac
Merge remote-tracking branch 'upstream/master' into nullMetadataInfo
CyrusNajmabadi May 11, 2017
f67c247
Filter projects based on language name
tmeschter May 11, 2017
6e011f2
Delete the PR branch if nothing to merge
drognanar May 11, 2017
d526325
Disable all tests.
CyrusNajmabadi May 11, 2017
902da97
Merge remote-tracking branch 'upstream/master' into blockSimplification
CyrusNajmabadi May 11, 2017
125ac47
Disable tests.
CyrusNajmabadi May 11, 2017
3fb3205
Merge remote-tracking branch 'upstream/master' into nullPaths
CyrusNajmabadi May 11, 2017
5b693df
Disable tests.
CyrusNajmabadi May 11, 2017
1da5b30
added comments
heejaechang May 11, 2017
8dae01b
Merge pull request #19408 from CyrusNajmabadi/nullMetadataInfo
CyrusNajmabadi May 11, 2017
781c5b0
Merge pull request #19446 from CyrusNajmabadi/nullPaths
CyrusNajmabadi May 11, 2017
9c6b618
Merge pull request #19311 from heejaechang/BulkSync
heejaechang May 11, 2017
3506fca
Merge pull request #19426 from CyrusNajmabadi/blockSimplification
CyrusNajmabadi May 11, 2017
722f011
Merge pull request #19440 from VSadov/fix19434
VSadov May 12, 2017
2ea8ebb
Merging ref assemblies feature into master
jcouv May 12, 2017
88cc266
Fix instrumentation for methods that have spans in multiple source fi…
shyamnamboodiripad May 9, 2017
24e7bb6
Add C# tests for instrumentation of methods with spans in multiple fi…
shyamnamboodiripad May 9, 2017
1fccde6
Add VB tests for instrumentation of methods with spans in multiple fi…
shyamnamboodiripad May 9, 2017
039cdb4
fixed crash on TS due to missing designer attribute service on OOP
heejaechang May 12, 2017
89d6bba
Merge pull request #19450 from tmeschter/FilterProjects
tmeschter May 12, 2017
9c9e183
Add CommonWithMetadataImportOptions
tmat May 12, 2017
52bbfde
Delete SymUnmanagedReaderExtensions.cs
tmat May 12, 2017
3994dc4
Added assertForeground flag to constructor
333fred May 12, 2017
479d1f1
Move all checks to foreground thread
333fred May 12, 2017
cbda7ae
Updated fwlink
333fred May 12, 2017
5eb7ed3
Removed extraneous itemgroup
333fred May 12, 2017
80fd73e
ReportWithoutCrash for failing to find whether the VSIX is installed
333fred May 12, 2017
b7fc91d
Added infodoc
333fred May 12, 2017
1bb1b45
Wrap long comment
333fred May 12, 2017
1d11b70
Refactored types
333fred May 12, 2017
efd8b64
Refactored logic into helpers.
333fred May 12, 2017
d757e2e
Merge pull request #19466 from heejaechang/fixTS
heejaechang May 12, 2017
e695bf0
Add a common base type of IDE and diagnostics VS performance tests.
mavasani May 12, 2017
d52ebe4
Merge remote-tracking branch 'upstream/master' into FixPerfTests
mavasani May 12, 2017
a2e2bf4
Remove refout package moniker from build (#19469)
jcouv May 13, 2017
02070e3
Reuse local rewriter to derive arguments for IHasArgumentsExpression
genlu May 3, 2017
b6fe1b5
Remove unused code
genlu May 4, 2017
e4844dd
Add binder to BoundCall, BoundIndexerAccess and BoundObjectCreationEx…
genlu May 5, 2017
c681653
Refactor LocalRewriter to remove IOperation's dependency on instance …
genlu May 6, 2017
7516025
Fix call to BoundObjectCreationExpression constructor in EE
genlu May 7, 2017
9b75d0a
Fix IArgument and ArgumentsInEvaluationOrder related tests
genlu May 7, 2017
ba40a98
Fix rebase error
genlu May 7, 2017
c85afe8
Move empty param array argument to the end of argument list
genlu May 7, 2017
f474bb2
Fix operation test references
genlu May 7, 2017
e855d4b
Fix value of CallerMemberName argument
genlu May 7, 2017
614f45f
Short circuit the logic when invocation has no arguments
genlu May 7, 2017
ec7bfaa
Refactor code around MakeArgumentsInEvaluationOrder based on review c…
genlu May 13, 2017
9f7540f
Fix crash caused by a combination of discard with arglist
genlu May 13, 2017
fa72dd6
Make `Patrameter` of all IArguments of invalid invocation to be null
genlu May 13, 2017
2367903
Fix error after rebase
genlu May 13, 2017
c0d1472
Pass build configuration when publishing bootstrap compiler
ellismg May 12, 2017
54d97dd
Remove code for generating constructors from class-decl, it will be p…
CyrusNajmabadi May 13, 2017
4c2862c
Move delegated constructor responsibility to the refactoring provider.
CyrusNajmabadi May 13, 2017
c81dfd3
Remove unneeded code.
CyrusNajmabadi May 13, 2017
5865073
Don't add punctuation in code.
CyrusNajmabadi May 13, 2017
a315a64
Fixup VB tests.
CyrusNajmabadi May 13, 2017
82373c8
Move type.
CyrusNajmabadi May 13, 2017
62705b3
Fixup test code.
CyrusNajmabadi May 13, 2017
fac36fe
Fixup C# test code.
CyrusNajmabadi May 13, 2017
c46b37e
Fixup C# tests.
CyrusNajmabadi May 13, 2017
9e95f3c
Add comment
CyrusNajmabadi May 14, 2017
23fa444
Add comment
CyrusNajmabadi May 14, 2017
cddbd90
Add comments
CyrusNajmabadi May 14, 2017
9781c81
Simplify code.
CyrusNajmabadi May 14, 2017
9437cf8
Remove unused usings.
CyrusNajmabadi May 14, 2017
05fc405
Fix bug when caret is at the end of an argument
alrz May 14, 2017
220d21e
Fix bug when caret is at the end of a numeric literal
alrz May 14, 2017
20079ae
Add test for omitted arguments
alrz May 14, 2017
7d1f983
Fix case that was causing us to not offer completion after a case-pat…
CyrusNajmabadi May 14, 2017
d987cfe
Wrap lines.
CyrusNajmabadi May 15, 2017
93cbd4c
Wrap lines.
CyrusNajmabadi May 15, 2017
ea9eb48
Remove unnecessary type parameters.
CyrusNajmabadi May 15, 2017
4a4fedd
Add new feature to suggest using 'default' instead of 'default(T)' wh…
CyrusNajmabadi May 15, 2017
068e0a7
Add user facing Code Style Option.
CyrusNajmabadi May 15, 2017
58a811e
Ensure fix-all doesn't break code.
CyrusNajmabadi May 15, 2017
dc8f7d6
remove unused usings.
CyrusNajmabadi May 15, 2017
78ac09a
Only supported in C# 7.1 and later.
CyrusNajmabadi May 15, 2017
c65efd1
Add tests.
CyrusNajmabadi May 15, 2017
4d14d98
Use 'default' when possible.
CyrusNajmabadi May 15, 2017
3aa3776
Fixup tests.
CyrusNajmabadi May 15, 2017
f3004af
Support default literals in metadata-as-source.
CyrusNajmabadi May 15, 2017
be03ae0
Fix test.
CyrusNajmabadi May 15, 2017
46643bb
Formatting.
CyrusNajmabadi May 15, 2017
ee580a8
Simplify code.
CyrusNajmabadi May 15, 2017
006df24
Simplify code.
CyrusNajmabadi May 15, 2017
8f804a7
Formatting.
CyrusNajmabadi May 15, 2017
490973a
Remove unnecessary casts.
CyrusNajmabadi May 15, 2017
28f0068
Mark recently completed C# 7.1 features as such (#19483)
jcouv May 15, 2017
24bff7e
Add IsLeftOfAssignment field to BoundIndexerAccess and fix indexer IA…
genlu May 15, 2017
ab816ba
Update comment.
CyrusNajmabadi May 15, 2017
277715d
Simplify code.
CyrusNajmabadi May 15, 2017
cf967be
Move version checking to single location.
CyrusNajmabadi May 15, 2017
5af03dc
Move all option checking to a single location.
CyrusNajmabadi May 15, 2017
58083ac
Reorder checks.
CyrusNajmabadi May 15, 2017
ea26f47
Copying content from WIKI
jaredpar May 11, 2017
8df2faf
Meet the intention of CONTRIBUTING.md
jaredpar May 11, 2017
bf7aaaf
Switch to DO / DO NOT style
jaredpar May 12, 2017
efd193c
Merge pull request #19448 from drognanar/mergeempty
drognanar May 15, 2017
658c728
Merge pull request #19401 from tmeschter/FixAnalyzerNodeHookup
srivatsn May 15, 2017
ef0f510
FOrmatting.
CyrusNajmabadi May 15, 2017
298e3b1
PR feedback
alrz May 15, 2017
0efcbc5
Add fast paths for analysis.
CyrusNajmabadi May 15, 2017
479f888
Add tests
alrz May 15, 2017
acb122e
Formatting.
alrz May 15, 2017
85de1be
Add tests.
CyrusNajmabadi May 15, 2017
a3124a7
Present feature to user as 'simplify default expression'.
CyrusNajmabadi May 15, 2017
eb4dc6c
Merge pull request #19468 from tmat/Cleanup2
tmat May 15, 2017
d483954
Remove reference to TestBase from CompilationVerifier
tmat May 11, 2017
83b213b
Unnest CompilationVerifier
tmat May 11, 2017
f68ed5a
Rename file
tmat May 11, 2017
a4491d2
Remove dependency on PDB reader from TestBase
tmat May 12, 2017
694edee
PDB extensions cleanup
tmat May 12, 2017
2469eda
Merge pull request #19365 from shyamnamboodiripad/FixMultiFileMethodI…
shyamnamboodiripad May 15, 2017
4b848b8
Fix FQN for CodeLens
panopticoncentral May 15, 2017
e758647
Rename file to match contained type name
sharwell May 13, 2017
d80ef0c
Move DocumentHighlights data types down to the 'Features' layer.
CyrusNajmabadi May 15, 2017
666c4eb
Skip test.
CyrusNajmabadi May 15, 2017
65b7418
Ensure versions match.
CyrusNajmabadi May 15, 2017
a3ccae5
Merge pull request #19481 from CyrusNajmabadi/constructorWork
CyrusNajmabadi May 15, 2017
3e570ab
Use xunitassertVersion
tmat May 15, 2017
0d8836a
Updated with final info bar text.
333fred May 15, 2017
1f41b08
Merge remote-tracking branch 'upstream/master' into fixfqn
panopticoncentral May 15, 2017
09088c6
Merge pull request #19499 from CyrusNajmabadi/defaultSimplification
CyrusNajmabadi May 15, 2017
d4ba609
Add ProjectReference guids
tmat May 15, 2017
4213595
Fix up merge
panopticoncentral May 15, 2017
dfae2e6
Fix perf regression in gotodef.
CyrusNajmabadi May 16, 2017
e9954ff
Merge remote-tracking branch 'upstream/master' into wtf1
CyrusNajmabadi May 16, 2017
b77e264
Convert if to switch.
CyrusNajmabadi May 16, 2017
8ea39b1
Addressed pr feedback.
333fred May 16, 2017
ba835cc
Merge remote-tracking branch 'dotnet/master' into ab-info-bar
333fred May 16, 2017
f88efe1
Add back 'beta2' nuget moniker for official builds.
shyamnamboodiripad May 16, 2017
d591a62
Add IL based tests for IArgument
genlu May 16, 2017
2a2bbd4
Merge pull request #19531 from CyrusNajmabadi/wtf1
CyrusNajmabadi May 16, 2017
f2311d9
Merge branch 'master' into ifToSwitch
CyrusNajmabadi May 16, 2017
7b3e373
Fixed syntax error
333fred May 16, 2017
717be53
Merge pull request #19546 from shyamnamboodiripad/FixNugetMoniker
jasonmalinowski May 16, 2017
648070f
Fix test verifier so it doesn't attemp to emit
genlu May 16, 2017
fdd0c5a
Check for missing hierarchies when mapping to Roslyn projects
tmeschter May 16, 2017
be202cf
Update comment
tmeschter May 16, 2017
e5189ff
Merge pull request #19447 from 333fred/ab-info-bar
333fred May 16, 2017
2ccd496
support CasePatternSwitchLabel in StatementSyntaxComparer (#19164)
ivanbasov May 16, 2017
c0e5a04
Clean up SyntaxNodeExtensions
alrz May 15, 2017
f907560
Do not leak out of the argument list when looking for an argument
alrz May 16, 2017
ea88bf6
Migrate BasicExpressionEvaluator Integration Tests from Tao (#19529)
ivanbasov May 16, 2017
7c0156f
Merge pull request #19543 from CyrusNajmabadi/ifToSwitch
CyrusNajmabadi May 16, 2017
7a1ac4e
Merge remote-tracking branch 'upstream/master' into moveDocHighlights
CyrusNajmabadi May 16, 2017
4566936
Reduce GC overhead of memory mapped files
sharwell May 15, 2017
73aad3f
Avoid releasing memory mapped file handles during shutdown
sharwell May 16, 2017
a71c2ee
Merge remote-tracking branch 'upstream/master' into gotodefPerf
CyrusNajmabadi May 16, 2017
0a52023
Merge pull request #19474 from dotnet/FixPerfTests
mavasani May 16, 2017
4a09b95
Additional use and development comments for MemoryMappedInfo
sharwell May 16, 2017
96990d2
Merge pull request #19559 from tmeschter/CheckForNullHierarchies
tmeschter May 16, 2017
babc76b
Try out another way to block.
CyrusNajmabadi May 16, 2017
936ae88
Address null ref.
CyrusNajmabadi May 16, 2017
d2a8042
Restore old APi to make migration easier.
CyrusNajmabadi May 17, 2017
b7b6638
Move file.
CyrusNajmabadi May 17, 2017
22e68c4
Improve diff.
CyrusNajmabadi May 17, 2017
ebaaf95
Improve diff.
CyrusNajmabadi May 17, 2017
fc4739a
Merge pull request #19521 from tmat/TestBase
tmat May 17, 2017
3361cb0
Address review comments
genlu May 17, 2017
a97af6e
Fix build break.
CyrusNajmabadi May 17, 2017
853efd2
Merge remote-tracking branch 'upstream/master' into gotodefPerf
CyrusNajmabadi May 17, 2017
7ee338d
Merge pull request #19522 from sharwell/mmf-overhead
sharwell May 17, 2017
1935170
LambdaRewriter should only assign proxies from locals in original fra…
cston May 5, 2017
30429b6
Merge pull request #19520 from panopticoncentral/fixfqn
May 17, 2017
123640d
enable symbols in CSI
filipw Feb 22, 2017
4ddd86d
improved decision logic around emitting symbols in CSI
filipw Feb 24, 2017
38ac197
move the script options back up
filipw Mar 1, 2017
59d9a6a
added a PDB verification test to CsiTests
filipw May 17, 2017
cff8fe3
use GetAwaiter() rather than .Result for script execution
filipw May 17, 2017
3f35adf
Merge pull request #19525 from CyrusNajmabadi/moveDocHighlights
CyrusNajmabadi May 17, 2017
3fb20b5
Merge pull request #19539 from CyrusNajmabadi/gotodefPerf
CyrusNajmabadi May 17, 2017
cfd402c
Refactor and renaming
genlu May 17, 2017
c5e64fe
Address review comments
genlu May 17, 2017
dccba9f
removed empty line
filipw May 17, 2017
f9f2b17
Merge pull request #19489 from alrz/bug-19175
sharwell May 17, 2017
683a457
Add missing sequence point in lowering of conditional statement (#19336)
jcouv May 17, 2017
22a15c0
More refactoring
genlu May 17, 2017
ac6e7c9
Minor change in tests
genlu May 17, 2017
1e444cf
Merge pull request #17379 from filipw/feature/csi-symbols
tmat May 17, 2017
a0ec732
bypass command line argument passing if no command line parser is ava…
brettfo May 16, 2017
62be375
Merge pull request #13608 from sjmelia/Issue_10428_formatting_of_empt…
sharwell May 18, 2017
b4d8e2c
Merge pull request #19487 from alrz/bug-19369
sharwell May 18, 2017
3f402e9
Merge pull request #19349 from cston/18273
cston May 18, 2017
c5f8e63
Merge pull request #19237 from genlu/fix2
genlu May 18, 2017
8bc010c
Skip unreachable catch clauses with constant false filter (#19294)
elijah6 May 18, 2017
b66f68c
Emitted pdb path should respect PathMap
jaredpar May 17, 2017
305d62b
Fix subtle issue around path separators
jaredpar May 17, 2017
32de942
Disable vsix check.
CyrusNajmabadi May 18, 2017
b90aa4c
Merge pull request #19632 from CyrusNajmabadi/disableVsixCheck
CyrusNajmabadi May 18, 2017
56045e8
Merge pull request #15706 from alrz/issue-15704
sharwell May 18, 2017
ba0cefe
Include overflow checks in tuple conversions (#19418)
cston May 18, 2017
501dbf6
Merge pull request #19566 from brettfo/bypass-setoptions
brettfo May 19, 2017
44d54db
Merge remote-tracking branch 'dotnet/master' into DefaultInterfaceImp…
AlekseyTs May 19, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed empty line
  • Loading branch information
filipw authored May 17, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit dccba9f667fb43f7d6ba3dd039dd872712b3ca41
Original file line number Diff line number Diff line change
@@ -121,7 +121,6 @@ private int RunInteractiveCore(ErrorLogger errorLogger)
return CommonCompiler.Failed;
}


var cancellationToken = new CancellationToken();

if (_compiler.Arguments.InteractiveMode)