Merge 'dotnet/master' into DefaultInterfaceImplementation #19648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lification Simplify serialization.
Fixes dotnet/project-system#2062. Currently we match a hierarchy node representing an analyzer in Solution Explorer up to the proper Roslyn `AnalyzerReference` based on the "display name"--basically, the name of the assembly without the extension. This mostly works, but you can run into problems if a project uses two different versions of the same analyzer, each with a different set of diagnostics. In this case expanding one of the analyzer nodes in Solution Explorer will show you the wrong set of diagnostics for one or the other, since they both have the same display name. To uniquely identify an analyzer assembly we should use its full path rather than the display name. However, the project system initially didn't expose the full path through the hierarchy node. This has been fixed, and now the full path is one of the components of the node's "canonical name", along with other bits of information such as the project directory and target framework. This commit updates our code to extract and use the full path instead of the display name.
Refactored IErrorReportingService
…et#19381) Tests only. No ask mode approval is required.
Re-enable roslyn analyzers on Roslyn.sln and update public api file f…
… for a piece of metadata.
Move DocumentHighlights data types down to the 'Features' layer.
Fix perf regression in gotodef.
Fix bug when caret is at the end of an argument
Enable debug information by default in CSI
…f_empty_for_loops Issue dotnet#10428: Formatting of empty loops now respects CSharp spacing options
Fix bug when caret is at the end of a numeric literal
LambdaRewriter should only assign proxies from locals in original frame in EE
Reuse local rewriter to derive arguments for IHasArgumentsExpression
The PDB path which is written into the PE file should respect the `/pathmap` option passed to the compiler. This is necessary to ensure that PEs can be deterministic when built from different source paths. The feature flag `pdb-path-determinism` is being kept for the time being. Even though it's a feature flag it still seems inappropriate to break customers in a point release. Deferring the removal until the next major release to give customers time to react. This issue tracks removing the flag: dotnet#19592 closes dotnet#9813
Disable vsix check.
Clarify error message when this is returned by reference
Include overflow checks in tuple conversions
bypass command line argument passing if no command line parser is available
AlekseyTs
added
Area-Compilers
Language-C#
Feature - Default Interface Impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.