Use langver=latest for scripting #21331
Conversation
jcouv
added
Area-Compilers
PR For Personal Review Only
| > Dim t = (a, 2) | ||
| > System.Console.Write(t.a) | ||
| «Red» | ||
| Public member 'a' on type 'ValueTuple(Of Object,Integer)' not found. |
There was a problem hiding this comment.
@tmat I was surprised by the behavior of VB scripting with tuple names. I'll investigate before merging this PR, but I wondered if the problem might be obvious to you. Any clues?
There was a problem hiding this comment.
VB interactive isn't complete. There is a lot of missing pieces currently. I'd not bother writing test for VB.
|
We'll also need to change this in the IDE (along with the binding flag to ignore corlib duplicate). |
|
Deploying from command-line worked. Verified the fix in dev hive. Thanks
|
|
👍 |
jcouv
removed
the
PR For Personal Review Only
|
@dotnet/roslyn-compiler for review. Thanks |
|
test windows_debug_vs-integration_prtest please |
|
test windows_release_vs-integration_prtest please |
|
test windows_debug_vs-integration_prtest please |
|
@dotnet/roslyn-compiler for review. Thanks |
|
|
||
| [Fact] | ||
| [WorkItem(21327, "https://github.com/dotnet/roslyn/issues/21327")] | ||
| public void InferredTupleNames() |
There was a problem hiding this comment.
Consider adding an equivalent test for VB.
There was a problem hiding this comment.
I had one, but removed it on advice of Tomas. VB scripting is not sufficiently functional at this point.
The test was producing a missing type error for ValueTuple type from some CompilerServices helper type.
|
LGTM |
|
note that this is already supported in Omnisharp and VS Code too (scripting is using latest lang version) 😄 OmniSharp/omnisharp-roslyn#935 |
…-literal-text * dotnet/features/ioperation: Fix NamedArgumentInParameterOrderWithDefaultValue test for new IOperation output. EnC and EE cleanup (dotnet#21226) Fix crash when encountering a parenthesized expression when converting an if to a switch. this makes OOM to crash OOP process. this won't crash VS, instead it will show info bar and notify users to close VS and re-open. Turn on ref assemblies in all projects (dotnet#21346) Re-baseline some emit tests Move MakeFrames logic into Analysis Use langver=latest for scripting (dotnet#21331) Enable skipped tests and fix them (dotnet#21335) Replace project reference with linked file removed left out from deleted esent code.
The Interactive Window was using langver=default. This PR makes it use langver=latest.
Fixes #21327