Enable skipped tests and fix them #21335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AutomaticStringLiteralCompletionTests.TestProprocessor_Backspace failed in windows_debug_unit32_prtest (details) |
|
test windows_debug_unit32_prtest please |
|
test windows_debug_vs-integration_prtest please |
1 similar comment
|
test windows_debug_vs-integration_prtest please |
|
windows_release_vs-integration_prtest failed with 262 failures on a test-only PR (details) @dotnet/roslyn-infrastructure Is this a known issue? |
|
test windows_release_vs-integration_prtest please |
|
@dotnet/roslyn-compiler for review. Thanks |
|
LGTM |
|
Merged with single review (test-only change). Thanks |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 10, 2017
…-literal-text * dotnet/features/ioperation: Fix NamedArgumentInParameterOrderWithDefaultValue test for new IOperation output. EnC and EE cleanup (dotnet#21226) Fix crash when encountering a parenthesized expression when converting an if to a switch. this makes OOM to crash OOP process. this won't crash VS, instead it will show info bar and notify users to close VS and re-open. Turn on ref assemblies in all projects (dotnet#21346) Re-baseline some emit tests Move MakeFrames logic into Analysis Use langver=latest for scripting (dotnet#21331) Enable skipped tests and fix them (dotnet#21335) Replace project reference with linked file removed left out from deleted esent code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were missing a
[Fact], but when the attribute was added, the tests failed and thus were skipped.This PR enables those tests and fixes them.
Fixes #21079