New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors INullCoalescingExpression to ICoalesce expression, and prop… #21458

Merged

333fred merged 3 commits into dotnet:features/ioperation from 333fred:inullcoalescingexpression-refactor

Aug 15, 2017

Member

333fred commented Aug 11, 2017

…erties to sensible names. Fixes #21290. Tagging @dotnet/analyzer-ioperation @dotnet/roslyn-compiler for review.


          Refactors INullCoalescingExpression to ICoalesce expression, and prop…

68bb957

…erties to sensible names.

333fred added Area-Analyzers Area-Compilers Feature - IOperation labels

333fred requested review from a team

August 11, 2017 21:03

dnfclas added the cla-already-signed label

Member Author

333fred commented Aug 11, 2017 •

edited

Loading

@dotnet/roslyn-infrastructure failure appears to be #21347.

Member Author

333fred commented Aug 11, 2017

@dotnet-bot retest windows_release_unit64_prtest please

genlu approved these changes

View reviewed changes

Member

genlu left a comment

Consider adding a VB test for ICoalesceExpression

mavasani approved these changes

View reviewed changes

cston approved these changes

View reviewed changes


          Merge remote-tracking branch 'dotnet/features/ioperation' into inullc…

efdd6cc

…oalescingexpression-refactor

* dotnet/features/ioperation:
  Update CSharpReplaceMethodWithPropertyService.cs
  Add VB side of fix.
  Remove unneeded function.
  Improve trivia preservation when converting methods into a property.
  VB side of do-not-simplify-nameof if it changes semantics.
  Do not simplify to an alias in a nameof if it changes the value of hte nameof.
  Include System.Runtime.Serialization.Primitives and System.Security.Cryptography.Csp in PortableFacades CoreXT package. (dotnet#21438)
  Address one more refactoring feedback
  Address PR feedback
  Fix possible race conditions in TestExtensionErrorHandler
  Fix expected test results to properly consider trivia
  Improve messages when tests fail due to expected text
  Default to considering trivia during testing
  Remove RemoveUnneededReferences from LamdaRewriter (dotnet#21367)
  Enable embedding sources to Windows PDBs (dotnet#21391)
  re-enabled assert we have disabled
  Do not insert Microsoft.DiaSymReader.Native (dotnet#21420)
  Resolving merge conflict
  Don't pick a project arbitrarily when navigating to symbols

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Portable/Operations/VisualBasicOperationFactory.vb Outdated

    
            @@ -286,7 +286,7 @@ Namespace Microsoft.CodeAnalysis.Semantics
          
                      End Function

                      Private Function CreateBoundMeReferenceOperation(boundMeReference As BoundMeReference) As IInstanceReferenceExpression

                          Dim instanceReferenceKind As InstanceReferenceKind = If(boundMeReference.WasCompilerGenerated, InstanceReferenceKind.Implicit, InstanceReferenceKind.Explicit)

                          Dim instanceReferenceKind As InstanceReferenceKind = If(boundMeReference.WasCompilerGenerated, instanceReferenceKind.Implicit, instanceReferenceKind.Explicit)

Contributor

AlekseyTs Aug 15, 2017 •

edited

Loading

instanceReferenceKind [](start = 107, length = 21)

This looks like an unintentional capitalization change. #Closed

Member Author

333fred Aug 15, 2017

I seriously do not know why these keep changing.

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Portable/Operations/VisualBasicOperationFactory.vb Outdated

    
            @@ -286,7 +286,7 @@ Namespace Microsoft.CodeAnalysis.Semantics
          
                      End Function

                      Private Function CreateBoundMeReferenceOperation(boundMeReference As BoundMeReference) As IInstanceReferenceExpression

                          Dim instanceReferenceKind As InstanceReferenceKind = If(boundMeReference.WasCompilerGenerated, InstanceReferenceKind.Implicit, InstanceReferenceKind.Explicit)

                          Dim instanceReferenceKind As InstanceReferenceKind = If(boundMeReference.WasCompilerGenerated, instanceReferenceKind.Implicit, instanceReferenceKind.Explicit)

Contributor

AlekseyTs Aug 15, 2017 •

edited

Loading

instanceReferenceKind [](start = 139, length = 21)

Here too #Closed

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Portable/Operations/VisualBasicOperationFactory.vb Outdated

@@ @@ -1073,7 +1073,7 @@ Namespace Microsoft.CodeAnalysis.Semantics @@
                       Private Function CreateBoundGotoStatementOperation(boundGotoStatement As BoundGotoStatement) As IBranchStatement
                           Dim target As ILabelSymbol = boundGotoStatement.Label
-                          Dim branchKind As BranchKind = BranchKind.GoTo
+                          Dim branchKind As BranchKind = branchKind.GoTo

Contributor

AlekseyTs Aug 15, 2017 •

edited

Loading

branchKind [](start = 43, length = 10)

Here too. #Closed

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Portable/Operations/VisualBasicOperationFactory.vb Outdated

@@ @@ -1083,7 +1083,7 @@ Namespace Microsoft.CodeAnalysis.Semantics @@
                       Private Function CreateBoundContinueStatementOperation(boundContinueStatement As BoundContinueStatement) As IBranchStatement
                           Dim target As ILabelSymbol = boundContinueStatement.Label
-                          Dim branchKind As BranchKind = BranchKind.Continue
+                          Dim branchKind As BranchKind = branchKind.Continue

Contributor

AlekseyTs Aug 15, 2017 •

edited

Loading

branchKind [](start = 43, length = 10)

Here too. #Closed

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Portable/Operations/VisualBasicOperationFactory.vb Outdated

@@ @@ -1093,7 +1093,7 @@ Namespace Microsoft.CodeAnalysis.Semantics @@
                       Private Function CreateBoundExitStatementOperation(boundExitStatement As BoundExitStatement) As IBranchStatement
                           Dim target As ILabelSymbol = boundExitStatement.Label
-                          Dim branchKind As BranchKind = BranchKind.Break
+                          Dim branchKind As BranchKind = branchKind.Break

Contributor

AlekseyTs Aug 15, 2017 •

edited

Loading

branchKind [](start = 43, length = 10)

Here too. #Closed

Contributor

AlekseyTs commented Aug 15, 2017 •

edited

Loading

Done with review pass. #Closed


          Fixed unintentional capitalization change.

ad58d12

Member Author

333fred commented Aug 15, 2017

@AlekseyTs fixed.

AlekseyTs approved these changes

View reviewed changes

Contributor

AlekseyTs left a comment

LGTM

333fred merged commit 41574d3 into dotnet:features/ioperation

333fred deleted the inullcoalescingexpression-refactor branch

August 15, 2017 19:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Analyzers Area-Compilers cla-already-signed Feature - IOperation