Merge 'dotnet/master' into DefaultInterfaceImplementation #21600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've been hanging the VS integration tests. I think CSharpToBasic or BasicToCSharp is the culprit (can't remember which I've seen).
This diagnostic is non-fatal but throws off a lot of developers who look at runtests.log. Avoid generating it by checking for directory existance before asking for files. Would be much better if we had non-throwing IO operations so we could avoid unnecessary Exists calls.
Replaces all the functionality that the old LambdaRewriter.Analysis visitors had and uses the new Scope tree instead. The first commit replaces most of the functionality while asserting equivalence with the old visitors, and the second commit removes all the old visitors and deletes the assertions.
…ogTests Disable GenerateTypeDialog tests
Move logic from the Makefile to either cibuild.sh or build/scripts
This is a follow-up to PR dotnet#21146, which was unable to be merged without keeping this flag ignore.
Changes the VS integration tests to use the common dump directory that all of our other infrastructure uses. Make it easy to debug failures when all of the dump files are in the same directory.
This broke in dotnet#21146, but the mac build was not tested.
…-of-aliases Correctly deduplicate metadata references for lightweight projects
Remove PackageTargetFallback that was necessary due to non-netstandard debugger packages
Hitting a file lock issue caused by parallel builds
…etPlacement Place caret in parameter list when generating constructors.
Fix a couple of test running bugs
…Trivia Preserve trivia better when converting if to switch.
…namic No pattern matching with dynamic.
Handle navigation to a doc ID without a corresponding doc
Change Generated-Code analysis to be a language service, not a workspace service
Set the CWD to the user profile dir, instead of current startup proj
Recent builds of the SDK introduced a bug around referencing netstandard 1.6 projects. This trigged on several Roslyn projects and cause build breaks with newer builds of VS. Suppressing the check for now. Will undo when we move to 2.0 SDK dotnet#21183
By default Invoke-WebRequest will fail if IE hasn't gone through first configuration setup on the machine. Parts of our infrastructure don't run IE and as a result our uses of Invoke-WebRequest were failing. Fixed by passing the UseBasicParsing switch.
Remove ignored flag
Recent builds of the SDK introduced a bug around referencing netstandard 1.6 projects. This trigged on several Roslyn projects and cause build breaks with newer builds of VS. Suppressing the check for now. Will undo when we move to 2.0 SDK dotnet#21183
Adds feature that helps convert keywords and symbols in doc comments to the appropriate tags.
…ankLines Do a better job with leading trivia on types when moving types to a new file.
Use default tuple fields in conversion since fields from inferred names are marked not usable in C#7
…r-20170815-070010 Merge dev15.4.x to master
Perform synthesis of closure methods in an early pass before visitation, meaning we no longer need to do a second visitation of the tree to lower local functions. The baselines have been changed because we now do closure id and synthessis in order of closure visitation, rather than bound node visitation. Closure visitation visits all the closures in a given scope, then recurs into nested scopes, while BoundNode visitation treats closures as scopes themselves, so nested closures are visited before closures declared in the same scope. Fixes https://github.com/dotnet/roslyn/projects/26#card-3753331
…Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
removed usage of ImmutableArray in json.net
3 product changes and 1 test change on sqlite persisted storage
…peParameter when it is called with Cref TypeParameter. (dotnet#21586) Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=410932. The fix mimics the way C# compiler handles Cref TypeParameters in the similar API.
Add test documentation to the PR template
AlekseyTs
added
Area-Compilers
Language-C#
Feature - Default Interface Impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.