'Use local function' suppress if used in expression tree. #24391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
UseLocalFunction_SuppressIfConvertedToExpression
branch
from
6f68b00 to
dd83cd1
Compare
|
Rebased and retargeted this test-only change. |
sharwell
approved these changes
Jan 23, 2018
MaStr11
commented
Jan 23, 2018
| @@ -1508,6 +1508,27 @@ public void Caller() | |||
| }"); | |||
| } | |||
|
|
|||
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseLocalFunction)] | |||
| [WorkItem(22672, "https://github.com/dotnet/roslyn/issues/24344")] | |||
There was a problem hiding this comment.
@sharwell The work item number is wrong here (22672 instead of 24344). I think I can't correct it because you changed the target branch and if I push it will bring other changes with it. Can you correct this or should we leave it?
sharwell
force-pushed
the
UseLocalFunction_SuppressIfConvertedToExpression
branch
from
dd83cd1 to
cbe7a5f
Compare
|
Fixed and just waiting for tests to pass now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case for #24344. Just an additional test case that verifies that this was already fixed in #23136.
Closes #24344