-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Merge master to features/param-nullchecking #36580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
16 commits merged into
features/param-nullchecking
from
merges/master-to-features/param-nullchecking
Jun 19, 2019
Merged
Merge master to features/param-nullchecking #36580
16 commits merged into
features/param-nullchecking
from
merges/master-to-features/param-nullchecking
Jun 19, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying value type when targetting a nullable value type.
…e of truth" Prior to this change, user settings could interact with .editorconfig in unknown ways to produce deviations in code style across a team which could not be controlled by simply updating .editorconfig. This change ensures that .editorconfig, when used, becomes the code style "source of truth" for affected documents.
During modifier ordering, 'const' is explicitly treated as a further restriction on 'static' and 'readonly'.
This reverts commit a2be1a4.
…ound a bug in TransformCompoundAssignmentLHS. Addressed PR feedback.
…-types * dotnet/master: (63 commits) Fix stack overflow in requesting syntax directives (#36347) crash on ClassifyUpdate for EventFields (#35962) Disable move type when the options service isn't present (#36334) Fix crash where type inference doing method inference needs to drop nullability Fix parsing bug in invalid using statements (#36428) Do not suggest or diagnose use compound assignment when right hand of binary operator is a throw expression Add option to emit nullable metadata for public members only (#36398) Added null checks on F# external access services (#36469) Deal with discovering extra .editorconfig files Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery Add support to VisualStudioMSBuildInstalled to support minimum versions Fix configuration of accessibilities in editorconfig Shorten a resource ID Revert "Extract the RDT implementation for Misc files and VS open file tracker" Add nullability support to use local function Add EditorFeatures.WPF dependency to F# ExternalAccess Ensure NullableWalker.AsMemberOfType locates the right new container for the member. (#36406) Replace `dynamic` with `object` when substituting constraints. (#36379) Add some string descriptions Adjust type of out var based on parameter state (#36284) ...
…metry added basic completion statement telemetry
Update naming styles to ensure .editorconfig is the code style "source of truth"
Implement subset-based ordering for naming rules
ghost
approved these changes
Jun 19, 2019
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/param-nullchecking.
git fetch --all git checkout merges/master-to-features/param-nullchecking git reset --hard upstream/features/param-nullchecking git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/param-nullchecking --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.