Skip to content

Conversation

@dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into features/param-nullchecking.

git fetch --all
git checkout merges/master-to-features/param-nullchecking
git reset --hard upstream/features/param-nullchecking
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-features/param-nullchecking --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

333fred and others added 16 commits June 11, 2019 11:00
…ying value type when targetting a nullable value type.
…e of truth"

Prior to this change, user settings could interact with .editorconfig in unknown ways to
produce deviations in code style across a team which could not be controlled by simply
updating .editorconfig. This change ensures that .editorconfig, when used, becomes the
code style "source of truth" for affected documents.
During modifier ordering, 'const' is explicitly treated as a further
restriction on 'static' and 'readonly'.
…ound a bug in TransformCompoundAssignmentLHS. Addressed PR feedback.
…-types

* dotnet/master: (63 commits)
  Fix stack overflow in requesting syntax directives (#36347)
  crash on ClassifyUpdate for EventFields (#35962)
  Disable move type when the options service isn't present (#36334)
  Fix crash where type inference doing method inference needs to drop nullability
  Fix parsing bug in invalid using statements (#36428)
  Do not suggest or diagnose use compound assignment when right hand of binary operator is a throw expression
  Add option to emit nullable metadata for public members only (#36398)
  Added null checks on F# external access services (#36469)
  Deal with discovering extra .editorconfig files
  Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery
  Add support to VisualStudioMSBuildInstalled to support minimum versions
  Fix configuration of accessibilities in editorconfig
  Shorten a resource ID
  Revert "Extract the RDT implementation for Misc files and VS open file tracker"
  Add nullability support to use local function
  Add EditorFeatures.WPF dependency to F# ExternalAccess
  Ensure NullableWalker.AsMemberOfType locates the right new container for the member. (#36406)
  Replace `dynamic` with `object` when substituting constraints. (#36379)
  Add some string descriptions
  Adjust type of out var based on parameter state (#36284)
  ...
…metry

added basic completion statement telemetry
Change `??=` for nullable value types as specified in LDM
Update naming styles to ensure .editorconfig is the code style "source of truth"
Implement subset-based ordering for naming rules
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 2490bf4 into features/param-nullchecking Jun 19, 2019
@ghost ghost deleted the merges/master-to-features/param-nullchecking branch June 19, 2019 13:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants