Skip to content

Consider nullability when comparing IReference instances during emit #38249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2019
Merged

Consider nullability when comparing IReference instances during emit #38249

merged 1 commit into from
Aug 23, 2019

Conversation

@cston
Copy link
Contributor

@cston cston commented Aug 23, 2019

Fixes #38183

@cston cston requested a review from a team as a code owner August 23, 2019 18:40
@cston
Copy link
Contributor Author

cston commented Aug 23, 2019

@dotnet/roslyn-compiler please review.

@cston cston requested a review from chsienki August 23, 2019 19:38
AlekseyTs
AlekseyTs approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@cston cston merged commit 98b82ec into dotnet:master Aug 23, 2019
@cston cston added this to the 16.4.P1 milestone Aug 23, 2019
@lambdageek lambdageek mentioned this pull request Aug 28, 2019
Closed
@cston cston mentioned this pull request Aug 29, 2019
Closed
@cston cston deleted the 38183 branch August 29, 2019 21:10
cston added a commit to cston/roslyn that referenced this pull request Aug 29, 2019
@cston
Consider nullability when comparing IReference instances during emit (d…
a7bd9bf 
…otnet#38249)
agocke pushed a commit that referenced this pull request Aug 30, 2019
@cston @agocke
Consider nullability when comparing IReference instances during emit (#…
c955f3c 
…38249) (#38396)

Port the fix for #38183 to 16.3.
@cston cston mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@chsienki chsienki Awaiting requested review from chsienki

Assignees

No one assigned

Labels

Area-Compilers Feature - Nullable Reference Types Nullable Reference Types

Projects

None yet

Milestone

16.4.P1

Development

Successfully merging this pull request may close these issues.

BadImageFormatException when calling Type.GetGenericTypeDefinition

4 participants

@cston @333fred @AlekseyTs @jcouv