Skip to content

Consider nullability when comparing IReference instances during emit (#38249) #38396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agocke merged 1 commit into from
Aug 30, 2019
Merged

Consider nullability when comparing IReference instances during emit (#38249) #38396

agocke merged 1 commit into from
Aug 30, 2019

Conversation

@cston
Copy link
Contributor

@cston cston commented Aug 29, 2019

Port the fix for #38183 to 16.3.

@cston cston requested a review from a team as a code owner August 29, 2019 21:18
@cston cston changed the base branch from master to release/dev16.3 August 29, 2019 21:19
@cston
Copy link
Contributor Author

cston commented Aug 29, 2019

@dotnet/roslyn-compiler please review.

@cston cston added this to the 16.3 milestone Aug 29, 2019
jcouv
jcouv approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@333fred
Copy link
Member

333fred commented Aug 29, 2019 •
edited
Loading

// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

Consider turning on nullability in all new files. #Closed

Refers to: src/Compilers/Core/Portable/Emit/MetadataEntityReferenceComparer.cs:1 in a7bd9bf. [](commit_id = a7bd9bf, deletion_comment = False)

@333fred
Copy link
Member

333fred commented Aug 29, 2019

// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

Ah, I see this is just a port. Fine as is then.

In reply to: 526381711 [](ancestors = 526381711)

Refers to: src/Compilers/Core/Portable/Emit/MetadataEntityReferenceComparer.cs:1 in a7bd9bf. [](commit_id = a7bd9bf, deletion_comment = False)

@akoeplinger akoeplinger mentioned this pull request Aug 30, 2019
Closed
@agocke agocke merged commit c955f3c into dotnet:release/dev16.3 Aug 30, 2019
@cston cston deleted the 38183-16.3 branch August 30, 2019 20:07
@cston cston mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

No one assigned

Labels

Approved to merge Area-Compilers ask-mode

Projects

None yet

Milestone

16.3

Development

Successfully merging this pull request may close these issues.

4 participants

@cston @333fred @jcouv @agocke