Annotate more compiler internal types #39053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Oct 4, 2019
src/Compilers/Core/Portable/Binding/AbstractLookupSymbolsInfo.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Oct 4, 2019
333fred
reviewed
Oct 4, 2019
333fred
reviewed
Oct 4, 2019
333fred
reviewed
Oct 4, 2019
src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/Symbols/PlaceholderMethodSymbol.cs
Show resolved
Hide resolved
chsienki
approved these changes
Oct 9, 2019
Member
chsienki
left a comment
chsienki
left a comment
There was a problem hiding this comment.
Some general comments, but mostly looks good.
I would like to see a link to an issue in the source for the #nullable disable sections, though.
src/Compilers/Core/Portable/Binding/AbstractLookupSymbolsInfo.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/CodeGen/PrivateImplementationDetails.cs
Outdated
Show resolved
Hide resolved
src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/Symbols/PlaceholderMethodSymbol.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are internal types. There may be some cases where an annotation was missed, but I used a working strategy of "when it doubt, prefer a non-nullable type if it builds successfully". This is a stepping stone for a follow-up pull request where I start to annotate
ISymboland derived types.