Simplify recent code with indexing operator #40410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Dec 16, 2019
| { | ||
| var previousToken = mod.GetPreviousToken(); | ||
| var lastSpan = spans[spans.Count - 1]; | ||
| var lastSpan = spans[^1]; |
Member
There was a problem hiding this comment.
i'm actually curious how this works. List<T> doesn't have an indexer that takes System.Index...
Contributor
Author
There was a problem hiding this comment.
The compiled code doesn't use Index at all. The bytecode is the same before and after this change.
genlu
approved these changes
Dec 30, 2019
dibarbet
added a commit
that referenced
this pull request
Jan 7, 2020
Revert "Merge pull request #40410 from sharwell/use-index"
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 8, 2020
* dotnet/master: (592 commits) Improve nullable analysis of local functions (dotnet#40422) Fix race condition in CodeFixService Annotate CSharpCompilation (dotnet#40752) Revert "Merge pull request dotnet#40765 from dibarbet/revert_use_index" More feedback address feedback More refactoring and hardening of remote calls (dotnet#40395) Update PublishData.json Unskip and fix integration test Update configs for preview 2 snap Improve error message for CS0191 (dotnet#40748) Revert "Merge pull request dotnet#40410 from sharwell/use-index" PR feedback Report erroneous implicit conversions in a switch expression (dotnet#40678) Ignore dynamic vs object, etc in pattern-matching machinery. (dotnet#40677) Handle dependent slots in pattern-matching null tests. (dotnet#39625) Pass non-null arguments to avoid nullability warning Update dependencies from https://github.com/dotnet/arcade build 20200104.1 (dotnet#40749) [master] Update dependencies from dotnet/arcade (dotnet#40718) Expose display option to add ! on non-nullable types (dotnet#40519) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexandRangeto the workspaces layer/cc @CyrusNajmabadi