Improve nullable analysis of local functions #40422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
force-pushed
the
nullable-localfunc-body
branch
from
d5bff1a to
a5054ef
Compare
This design tries to meld better analysis of nullable reference types in local functions with performance. To keep the common case one pass, local functions are analyzed using the starting state that is an intersection of all the states before its usages (calls, delegate conversions, etc), but the results of variables made nullable or non-nullable inside the local function do not propagate to the callers.
agocke
force-pushed
the
nullable-localfunc-body
branch
from
a5054ef to
58db000
Compare
333fred
reviewed
Dec 17, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
Outdated
Show resolved
Hide resolved
Member
|
Could you add the test shown in #40157? How does it interact with this change? |
333fred
reviewed
Dec 17, 2019
Member
|
Done review pass (commit 1) |
333fred
approved these changes
Dec 18, 2019
Member
Author
I didn't try to address that. I can see two possible specs for the behavior in the absence of a call: we could treat captured variables as always being non-null, or we use the annotation. My preference would be on the first, but I don't think we've made a decision either way. |
Member
|
I'll take a look shortly. |
Member
|
@agocke Anything holding us back from merging this? |
Member
|
Merged to unblock my other PR. Andy said it's ready to merge |
Member
Author
|
SGTM thanks |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 8, 2020
* dotnet/master: (592 commits) Improve nullable analysis of local functions (dotnet#40422) Fix race condition in CodeFixService Annotate CSharpCompilation (dotnet#40752) Revert "Merge pull request dotnet#40765 from dibarbet/revert_use_index" More feedback address feedback More refactoring and hardening of remote calls (dotnet#40395) Update PublishData.json Unskip and fix integration test Update configs for preview 2 snap Improve error message for CS0191 (dotnet#40748) Revert "Merge pull request dotnet#40410 from sharwell/use-index" PR feedback Report erroneous implicit conversions in a switch expression (dotnet#40678) Ignore dynamic vs object, etc in pattern-matching machinery. (dotnet#40677) Handle dependent slots in pattern-matching null tests. (dotnet#39625) Pass non-null arguments to avoid nullability warning Update dependencies from https://github.com/dotnet/arcade build 20200104.1 (dotnet#40749) [master] Update dependencies from dotnet/arcade (dotnet#40718) Expose display option to add ! on non-nullable types (dotnet#40519) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design tries to meld better analysis of nullable reference types in
local functions with performance. To keep the common case one pass,
local functions are analyzed using the starting state that is an
intersection of all the states before its usages (calls, delegate
conversions, etc), but the results of variables made nullable or
non-nullable inside the local function do not propagate to the callers.