Skip to content

Spread out code inside decompiled methods to make things look better. #42826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6 commits merged into from
Mar 28, 2020
Merged

Spread out code inside decompiled methods to make things look better. #42826

6 commits merged into from
Mar 28, 2020

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Mar 27, 2020 •
edited
Loading

Followup to: #42809

Before:

image

After:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 27, 2020 03:20
JoeRobich
JoeRobich reviewed Mar 27, 2020
View reviewed changes
src/Features/CSharp/Portable/DocumentationComments/DocCommentConverter.cs Outdated
Copy link
Member

@JoeRobich JoeRobich Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, but why do we change DocComments to RegularComments?

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, but why do we change DocComments to RegularComments?

Primarily because doc comments are terrible to read in code. They're desigend to be structured, and then rendered nicely by some presenter (i.e. quick-info, or html docs), but they themselves are really unpleasant to look at as the first class source of info.

We convert to just a really simple textual view that puts the content forward and basically hides all the structure tags.

Copy link
Contributor

@sharwell sharwell Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... hides all the structure tags ...

Also loses semantic references and syntax highlighting 😢

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just have to write some tools for that :)

@sharwell
Copy link
Contributor

sharwell commented Mar 28, 2020

@CyrusNajmabadi Can you back out #42809 from this change? I prefer to keep the spacing between members under the approach of #42850.

@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Mar 28, 2020

@sharwell . Yes, that's my plan once your PR goes in.

@CyrusNajmabadi CyrusNajmabadi requested a review from sharwell March 28, 2020 05:36
ghost
ghost approved these changes Mar 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit b9b0bc6 into dotnet:master Mar 28, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the decompileSpacing2 branch March 29, 2020 03:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich left review comments

+2 more reviewers

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrusNajmabadi @sharwell @JoeRobich