Collapse empty lines between elements of the same kind #42850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I added a bunch of tests. It's not perfect, but there were no tests of this behavior beforehand so it's an improvement 😂 |
Member
|
You might want to add pictures here, in case anyone comes to this PR in the future :) |
src/Features/CSharp/Portable/Structure/Providers/AccessorDeclarationStructureProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Structure/Providers/ConstructorDeclarationStructureProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Structure/Providers/DestructorDeclarationStructureProvider.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/Structure/Providers/EnumDeclarationStructureProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Structure/Providers/EventDeclarationStructureProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Structure/Providers/IndexerDeclarationStructureProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Structure/Providers/NamespaceDeclarationStructureProvider.cs
Outdated
Show resolved
Hide resolved
Member
|
Overalll LGTM. have some potential tiny style questions about spacing of constructs. But i leave that to you in terms of how it feels. Signing off on this approach and practically any reasonable tweaks you make to it. <3 |
CyrusNajmabadi
approved these changes
Mar 28, 2020
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates Collapse to Definitions to produce a view closer to Metadata As Source, where empty lines are omitted between collapsed elements of the same kind. Since the blank lines are included in the folding region, this feature works without removing the blank lines from the original source.
Supersedes #42809
Go To Decompiled Source
Before
After
Collapse to Definitions
Before
After