-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to features/source-generators #44111
Merged
265 commits merged into
features/source-generators
from
merges/master-to-features/source-generators
May 11, 2020
Merged
Merge master to features/source-generators #44111
265 commits merged into
features/source-generators
from
merges/master-to-features/source-generators
May 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceDistanceComparer.cs Co-Authored-By: Andrew Hall <ryzngard@live.com>
…ceDistanceComparer.cs Co-Authored-By: Andrew Hall <ryzngard@live.com>
…sualBasicAddExplicitCastCodeFixProvider.vb Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…sualBasicAddExplicitCastCodeFixProvider.vb Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…ddExplicitCastCodeFixProvider.cs Co-Authored-By: Andrew Hall <ryzngard@live.com>
…ddExplicitCastCodeFixProvider.cs Co-Authored-By: Andrew Hall <ryzngard@live.com>
…-to-master Merge release/dev16.7-preview1 to master
This change skips executing analyzers by default on explicit builds (both inside VS and on command line prompt). This should speed up the overall build time of Roslyn.sln when building locally. The only time a developer would want analyzers to run locally outside the typing scenario is to compute the exact set of warnings for a specific project/solution before pushing your local changes to CI. They can now perform the following steps to achieve this: 1. On command line: Build with `/p:UseRoslynAnalyzers=true` or `/p:RunCodeAnalysis=true` 2. Inside VS: 1. Start VS with `%RoslynEnforceCodeStyle% = true`, all builds in VS should execute analyzers 2. Use `Run Code Analysis` command from `Analyze` menu on selected project/solution
… CI failure" This reverts commit 71716fd.
Cache export provider factories
Exclude csc.exe from optprof profiling
Skip executing analyzers by default on local builds for solutions in the repo
…Rename Remove changes to XAML and F# IInlineRenameInfo interfaces
…-fix Code fix for CS0109 (The new keyword is not required)
When caching dependent-type-results, don't try to re-infer the originating project.
ghost
approved these changes
May 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
ghost
deleted the
merges/master-to-features/source-generators
branch
May 11, 2020 19:48
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/source-generators.
git fetch --all git checkout merges/master-to-features/source-generators git reset --hard upstream/features/source-generators git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/source-generators --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.