Merge master to features/source-generators #45921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update static lambdas from master
…c-lambdas Merge master to features/static-lambdas
…c-lambdas Merge master to features/static-lambdas
…features/static-lambdas
…c-lambdas Merge master to features/static-lambdas
…c-lambdas Merge master to features/static-lambdas
…c-lambdas Merge master to features/static-lambdas
…c-lambdas Merge master to features/static-lambdas
…features/static-lambdas
… for Casts in SimpleArguments
…c-lambdas Merge master to features/static-lambdas
Before rewriting the statement, it now checks to see if the Switch expression is being implicitly converted. If so, it explicitly casts the expression to mach the label constant and then rewrites. If not, it rewrites as before.
This will now explicitly cast the switch expression to its converted type every time. If the cast is not needed then the Simplifier will remove the cast. The cast is now made in the ConvertSwitchStatementToExpressionCodeFixProvider.Rewriter.cs rather than ConvertSwitchStatementToExpressionCodeFixProvider.cs
…c-lambdas Merge master to features/static-lambdas
Now the ConvertSwitchStatementToExpressionCodeFixProvider.Rewriter.cs applies an explicit cast when it is applicable
…latest design. (#45831) Related to #45296. From specification: If the record is derived from `object`, the record type includes a synthesized readonly property equivalent to a property declared as follows: ```C# protected Type EqualityContract { get; }; ``` The property is `virtual` unless the record type is `sealed`. The property can be declared explicitly. It is an error if the explicit declaration does not match the expected signature or accessibility, or if the explicit declaration doesn't allow overiding it in a derived type and the record type is not `sealed`. If the record type is derived from a base record type `Base`, the record type includes a synthesized readonly property equivalent to a property declared as follows: ```C# protected override Type EqualityContract { get; }; ``` The property can be declared explicitly. It is an error if the explicit declaration does not match the expected signature or accessibility, or if the explicit declaration doesn't allow overiding it in a derived type and the record type is not `sealed`. It is an error if either synthesized, or explicitly declared property doesn't override a property with this signature in the record type `Base` (for example, if the property is missing in the `Base`, or sealed, or not virtual, etc.). The synthesized property returns `typeof(R)` where `R` is the record type.
Remove trailing commas during conversion to class
RemotableDataService refactoring
…re either test or product bugs
…roviderSemantic Skip flaky test
[Dogfooding] Extend existing IDE code style enforcement rules to EditorFeatures layer
Fix VB case correction for named tuple identifiers
* Use TestHost consistently * Comments * Fix * RenameTestHost * Renaming
Remove experimental feed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/source-generators.
git fetch --all git checkout merges/master-to-features/source-generators git reset --hard upstream/features/source-generators git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/source-generators --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.