Skip to content

Classify ??= as an operator. #45999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Classify ??= as an operator. #45999

merged 1 commit into from
Jul 16, 2020

Conversation

@pawchen
Copy link
Contributor

@pawchen pawchen commented Jul 15, 2020

Fixes #45319

@pawchen pawchen requested review from a team as code owners July 15, 2020 07:30
@333fred
Copy link
Member

333fred commented Jul 15, 2020

Related: #29948

333fred
333fred approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@333fred
Copy link
Member

333fred commented Jul 15, 2020

@dotnet/roslyn-compiler for a second, 1-line review.

@333fred 333fred added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 16, 2020
@333fred 333fred merged commit 2bb5a15 into dotnet:master Jul 16, 2020
@ghost ghost added this to the Next milestone Jul 16, 2020
@333fred
Copy link
Member

333fred commented Jul 16, 2020

Thanks @DiryBoy!

@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
@pawchen pawchen deleted the qqe branch November 19, 2021 15:47
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@333fred 333fred 333fred approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

16.8.P1

Development

Successfully merging this pull request may close these issues.

??= is not colorized as operator

7 participants

@pawchen @333fred @jaredpar @JoeRobich @sharwell @CyrusNajmabadi @jinujoseph