Skip to content

Classify ??= as an operator. #45999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Classify ??= as an operator. #45999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Syntax/SyntaxKindFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public static IEnumerable<SyntaxKind> GetPreprocessorKeywordKinds()

public static bool IsPunctuation(SyntaxKind kind)
{
return kind >= SyntaxKind.TildeToken && kind <= SyntaxKind.PercentEqualsToken;
return kind >= SyntaxKind.TildeToken && kind <= SyntaxKind.QuestionQuestionEqualsToken;
}

public static bool IsLanguagePunctuation(SyntaxKind kind)
Expand Down
5 changes: 5 additions & 0 deletions src/EditorFeatures/CSharpTest/Classification/SyntacticClassifierTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3141,6 +3141,7 @@ public void method()
i ^= i;
i <<= i;
i >>= i;
i ??= i;
object s = x => x + 1;
Point point;
unsafe
Expand Down Expand Up @@ -3374,6 +3375,10 @@ public void method()
Operators.GreaterThanGreaterThanEquals,
Identifier("i"),
Punctuation.Semicolon,
Identifier("i"),
Operators.QuestionQuestionEquals,
Identifier("i"),
Punctuation.Semicolon,
Keyword("object"),
Local("s"),
Operators.Equals,
Expand Down
1 change: 1 addition & 0 deletions src/EditorFeatures/TestUtilities/Classification/FormattedClassifications.Operators.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ private static FormattedClassification New(string text)
public static FormattedClassification PlusEquals { get; } = New("+=");
public static FormattedClassification PlusPlus { get; } = New("++");
public static FormattedClassification QuestionMark { get; } = New("?");
public static FormattedClassification QuestionQuestionEquals { get; } = New("??=");
public static FormattedClassification Slash { get; } = New("/");
public static FormattedClassification SlashEquals { get; } = New("/=");
public static FormattedClassification Tilde { get; } = New("~");
Expand Down
1 change: 1 addition & 0 deletions src/Workspaces/CSharp/Portable/Classification/ClassificationHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ private static bool IsOperator(this SyntaxKind kind)
case SyntaxKind.MinusEqualsToken:
case SyntaxKind.CaretEqualsToken:
case SyntaxKind.PercentEqualsToken:
case SyntaxKind.QuestionQuestionEqualsToken:
return true;

default:
Expand Down