Bump versions of System.Collections.Immutable and System.Reflection.Metadata to consume the new function pointer metadata changes. #46176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
added
Area-Infrastructure
Feature - Function Pointers
sharwell
reviewed
Jul 22, 2020
sharwell
reviewed
Jul 22, 2020
src/Compilers/Core/Portable/InternalUtilities/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jul 22, 2020
src/Workspaces/Core/Portable/Diagnostics/DiagnosticAnalysisResultMap.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jul 22, 2020
...tiesAndExtensions/Compiler/Core/Utilities/CompilerUtilities/ImmutableDictionaryExtensions.cs
Outdated
Show resolved
Hide resolved
sharwell
previously approved these changes
Jul 22, 2020
Contributor
sharwell
left a comment
sharwell
left a comment
There was a problem hiding this comment.
Can't speak to the specific versions in use, but the fallout appears fine to this point.
Member
Author
|
@sharwell There's a new set of changes in the IDE layer (had to boot into Windows again as I couldn't build those files on Linux), please take another look. |
jaredpar
approved these changes
Jul 22, 2020
sharwell
reviewed
Jul 22, 2020
src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Jul 22, 2020
Contributor
|
@333fred I would need to see a test insertion pass to sign off on this. |
…etadata to consume the new function pointer metadata changes.
333fred
force-pushed
the
update-references
branch
from
36abf71 to
3667c3f
Compare
Member
Author
|
Successful test insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/263088 |
ghost
added this to the
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to use this to run PR validation for inserting into VS.