-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TODO from public documentation #47370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than remove the semantic reference (the <see>
element), you can change <remarks>
to <devdoc>
which continues to be validated by the compiler but doesn't show in rendered documentation.
Thanks. I didn't know about the existence of devdoc. |
It's a made-up XML element historically used for this purpose. The documentation compiler defines several well-known elements, but tools are allowed to define and/or use others. |
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
@sharwell I found that a devdoc was used in dotnet/runtime but was included in the public documentation: https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.threadwaitreason?view=netcore-3.1 The XML for the doc page include the exact same text as summary. Any idea why this is happening? Was that a manual change to the generated XML? |
Here's the XML documentation for The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 3)
Squashed/merged. Thanks @Youssef1313 ! |
Fixes #47366
There are more TODOs in triple-slash doc comments. But I only found this one in a public API.