Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO from public documentation #47370

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Remove TODO from public documentation #47370

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c38888
Remove TODO from public documentation
Youssef1313 Sep 2, 2020
7e4b164
Update SyntaxNode.cs
Youssef1313 Sep 2, 2020
04f1407
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
Youssef1313 Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,12 +833,10 @@ public IEnumerable<SyntaxNodeOrToken> DescendantNodesAndTokensAndSelf(TextSpan s
/// If <paramref name="getInnermostNodeForTie"/> is true, then it returns lowest descending node encompassing the given <paramref name="span"/>.
/// Otherwise, it returns the outermost node encompassing the given <paramref name="span"/>.
/// </summary>
/// <remarks>
/// TODO: This should probably be reimplemented with <see cref="ChildThatContainsPosition"/>
/// </remarks>
/// <exception cref="ArgumentOutOfRangeException">This exception is thrown if <see cref="FullSpan"/> doesn't contain the given span.</exception>
public SyntaxNode FindNode(TextSpan span, bool findInsideTrivia = false, bool getInnermostNodeForTie = false)
{
// TODO: This should probably be reimplemented with <see cref="ChildThatContainsPosition"/>
if (!this.FullSpan.Contains(span))
{
throw new ArgumentOutOfRangeException(nameof(span));
Expand Down