Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to features/source-generators #47660

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into features/source-generators.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/master-to-features/source-generators
git reset --hard upstream/features/source-generators
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-features/source-generators --force

tiesmaster and others added 30 commits October 18, 2019 23:40
Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
In order to fix compilation errors in the CodeStyle lib.

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
as was discussed by the design review for #36913.

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
dibarbet and others added 18 commits September 10, 2020 15:17
show void keyword in completion after readonly in struct
Fix F1 keywords clashing for !_CSharpKeyword
Signature help should use SymbolDisplayMiscellaneousOptions.AllowDefaultLiteral
* Brokered service

* TodoCommentService ISB

* Generate PkgDef entries

* Generate VSIX manifest assets

* Brokered services

* Error reporting

* BrokeredServiceConnection

* Enable cancellation on disconnection

* Error handling

* Remove usage of WellKnownServiceHubService for brokered services

* Semantic classification services

* Fix streaming service calls

* Propagate cancellation token to all services

* Misc

* Fixes

* Feedback

* Comments

* Dispose feedback

* RPC fixes

* Rename brokered services

* Prefix services with Microsoft.VisualStudio

* Fix

* Fix cancelation of OOP analyzer requests
Upgrade MS.CA.Elfie version
Check EditorBrowsable attribute for unimported ext-methods completion
@ghost
Copy link

ghost commented Sep 13, 2020

Hello @dotnet-bot!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 2fb8f39 into features/source-generators Sep 28, 2020
@ghost ghost deleted the merges/master-to-features/source-generators branch September 28, 2020 18:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.