Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev16.8 to master #47962

Merged
merged 11 commits into from
Sep 24, 2020
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev16.8 into master.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/release/dev16.8-to-master
git reset --hard upstream/master
git merge upstream/release/dev16.8
# Fix merge conflicts
git commit
git push upstream merges/release/dev16.8-to-master --force

AlekseyTs and others added 11 commits July 22, 2020 11:34
Merge master into features/VarianceSafetyForStaticMembers
…rs_100

Merge 'upstream/master' into VarianceSafetyForStaticMembers
…rs_102

Remove PROTOTYPE comments from tests for variance safety with static members.
…icMembers' into VarianceSafetyForStaticMembers_103
…odeStyle layer

Fixes #47942
This is a special IDE-only analyzer that should not be exported in the CodeStyle NuGet package. We still want to retain the code in the shared analyzer layer to allow different analyzer hosts to be able to explicitly instantiate it and enforce it on command line from the CodeStyle package.
…rs_103

Merge VarianceSafetyForStaticMembers into dev16.8
Do not export IDE0079 (remove unnecessary suppressions) analyzer in C…
@ghost
Copy link

ghost commented Sep 23, 2020

Hello @dotnet-bot!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dibarbet dibarbet merged commit 5c09245 into master Sep 24, 2020
@ghost ghost added this to the Next milestone Sep 24, 2020
@dibarbet dibarbet deleted the merges/release/dev16.8-to-master branch September 24, 2020 06:39
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants