Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'upstream/master' into VarianceSafetyForStaticMembers #47888

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

Youssef1313 and others added 30 commits September 9, 2020 15:23
Document InstallTraceListener conditions
…Service.cs

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Trigger completion in 'new()' expression
Previously we tried this by simply parsing the string as XML, and if
that succeeded great; otherwise we'd catch the first-chance exception
and then treat it as a regular file. This is problematic if you intend
for your test to be using XML, but you have some typo that prevents it
from parsing properly; in that case the fallback of a single file
with the XML as contents may result in tests incorrectly passing if
the compiler succeeds in producing a valid enough tree. It's also then
makes the XML error easy to understand since you'll get the parse error.
Fix for issue 46942. VSIX suppressors do not run when Nuget analyzers / suppressors are installed.
Enforce more code style in Compilers area
RikkiGibson and others added 20 commits September 18, 2020 17:25
Some more error list performance improvements
Allow genearted local function parameter name to shadow variables
…opening-source-generated-files

Fix issues with opening source generated files
Support category-based exclusions in user option for unnecessary supp…
…otnet#47461)

* Use MessagePack for ISB serialization

* DocumentHighlighting service

* Renamer, EncapsulateField, TupleToStruct services

* SymbolFinder and FindUsages services

* NavigateToSearch service

* FindUsages, References fixes

* AddImport service

* SymbolSearchUpdate service

* ExtensionMethodImportCompletion service

* DependentTypeFinder service

* GlobalNotificationDelivery service

* CodeLensReferences service

* Remove CodeAnalysis service

* Remove unused code

* Fix warnings.

* Remove unused

* Error reporting and logging

* Update StreamJsonRpc to 2.6.86-alpha

* Improve callback error handling.

* Update Watson reporting

* PR feedback

* Fix tests

* Fixes

* Remove unused field

* Rename shutdown service

* Switch diagnostic serialization from ObjectReader/Writer serializer to MessagePack

* Fix diagnostic reporting issue in ASP.NET apps
Update Extract Method to support top-level statements
Initialize FatalError handlers in VS and OOP
Update SyntaxNodeAnalysisContext.Compilation to not return null
Improve comments for top-level statement insertion
* Don't offer to fix naming on positional record parameters

* Nullable enable

* Fix formatting

* Fix issue with nested constructors and parameters

* Rebase and remove ThrowIfNull
@ghost
Copy link

ghost commented Sep 21, 2020

Hello @AlekseyTs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 77d1173 into dotnet:features/VarianceSafetyForStaticMembers Sep 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.