Merge 'upstream/master' into VarianceSafetyForStaticMembers #47888

Document InstallTraceListener conditions

…Service.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>

Trigger completion in 'new()' expression

Previously we tried this by simply parsing the string as XML, and if that succeeded great; otherwise we'd catch the first-chance exception and then treat it as a regular file. This is problematic if you intend for your test to be using XML, but you have some typo that prevents it from parsing properly; in that case the fallback of a single file with the XML as contents may result in tests incorrectly passing if the compiler succeeds in producing a valid enough tree. It's also then makes the XML error easy to understand since you'll get the parse error.

… pointer

Fix for issue 46942. VSIX suppressors do not run when Nuget analyzers / suppressors are installed.

Enforce more code style in Compilers area

…nStatic Don't offer to make local functions static if they use other local functions

Fix interactive window integration test failures

Run continuations asynchronously where necessary

…nter-calling-convention-support Add IDE support for function pointer calling conventions

Correctly get binder when a local function is the first thing in top level statements

…-master Merge release/dev16.8 to master

show void keyword in completion after readonly in struct

…-master Merge release/dev16.8 to master

Fix F1 keywords clashing for !_CSharpKeyword

Add 64-bit xunit.console process

Signature help should use SymbolDisplayMiscellaneousOptions.AllowDefaultLiteral

Fixes dotnet#47471

* Brokered service * TodoCommentService ISB * Generate PkgDef entries * Generate VSIX manifest assets * Brokered services * Error reporting * BrokeredServiceConnection * Enable cancellation on disconnection * Error handling * Remove usage of WellKnownServiceHubService for brokered services * Semantic classification services * Fix streaming service calls * Propagate cancellation token to all services * Misc * Fixes * Feedback * Comments * Dispose feedback * RPC fixes * Rename brokered services * Prefix services with Microsoft.VisualStudio * Fix * Fix cancelation of OOP analyzer requests

Upgrade MS.CA.Elfie version

This allows `init` properties on readonly structs, readonly properties in structs, and allows `init` accessors to be declared readonly themselves. Fixes dotnet#47612.

Check EditorBrowsable attribute for unimported ext-methods completion

This listener conflicts with ThrowingTraceListener, and significantly impairs the ability to identify test failures.

Currently the incremental parser is not producing trees with the correct text. However, this bug was introduced in the past and is failing now that debug assertions are checked in builds. See dotnet#47610

Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>

Fix incorrect mapping of nodes/tokens in VBgrammar generator

* Fix steaming ISB service hang * Fix comment

Enable unused integration test parameter

…states. (dotnet#47567) * Decision dag: union the set of values when there are two predecessor states. If a state has no set of values for a temp on one of the edges, that means it is unrestricted. This fixes a bug in decision dag construction. I was not able to construct a test that is affected, but the change makes a visible difference in an internal dump of the decision dag for the newly added test `MultiplePathsToState_01`, which we walked through in a compiler team meeting on 2020-09-09. * Use a builder as suggested in review.

…net#47645) Related to dotnet#47471

Switch to an async nuget api to avoid blocking the UI thread.

Work towards addressing large number of recent VS Feedback requests when user invokes an explicit build: - https://developercommunity.visualstudio.com/content/problem/1173125/error-list-sometimes-goes-empty-after-a-build.html - https://developercommunity.visualstudio.com/content/problem/1154411/errors-persist-in-the-error-list-even-after-fixing.html - https://developercommunity.visualstudio.com/content/problem/1149465/error-list-doesnt-show-errors-in-167x.html - https://developercommunity.visualstudio.com/content/problem/1142347/the-error-list-cannot-be-refreshed-in-real-time-ev.html - https://developercommunity.visualstudio.com/content/problem/1135858/error-list-errors-are-not-removed-after-successful.html - https://developercommunity.visualstudio.com/content/problem/1134412/failed-compilation-does-not-show-errors.html - https://developercommunity.visualstudio.com/content/problem/1126855/compile-error-view-major-bugs.html - https://developercommunity.visualstudio.com/content/problem/1053969/error-list-not-show.html Changes: - Performance - Refresh error list during the build, as and when we either clear diagnostics or add diagnostics from build into our in progress build state. Current implementation defers all updates to the end of the build, which has couple of disadvantages: - It adds to overall computuation within devenv.exe at end of the build, so it takes a longer time for error list to reach the stable state. This confuses the user into thinking error list has updated, but just has stale data. - Error list shows stale results during the build and some time after the build completes till we complete de-duplication of build and live diagnostics. - Avoid pre-fetching compilation for all projects everytime we de-dupe build and live diagnostics after build completes. This causes the major compute overhead from the time build completes to error list is updated (could even be a few minutes). The only reason we need the compilation for this step is to determine if an analyzer is a compilation end analyzer or not, so we can grouo the reported analyzer diagnostics into live or build-only bucket correctly. I will work on a separate follow-up change to avoid this computation completely, so we don't need to fetch compilation to determine is compilation end analyzer. - Functional - Update error list's "Build + Intellisense" setting to correctly show non-stable state (i.e. `Error List...`) while the build is executing and we are de-duping build and live diagnostics after build completes. Currently, the stable state for this setting only shows non-stable when solution crawler is running. This leads to error list incorrectly showing stable state when a build completes, but we are still de-duping diagnostics and solution crawler has not yet restarted. This confuses the users into thinking error list has finished all updates and has stale diagnostics. - Clear diagnostics for transitive projects: When we receive ClearDiagnostics(project) callback during build for projects getting re-built as part of the build, we now clear diagnostics for that project and also for all projects that transitively depend on that project. Not clearing transitively dependent project diagnostics will lead to stale diagnostics for these dependent projects in the error list, especially when user fixes errors in the core project in the dependency chain.

…47654)

…mments Fix convert-to-switch handling of comments at the end of blocks

This is a mitigation for the threading issue discussed in dotnet#35818. When building VS, there is a flaky threading issue where an interpolation with multiple parts can end up with different nodes on different threads, causing an optimization in `SetParentOperation(ImmutableArray)` to be invalid. This makes the optimization much narrower, ensuring that it is actually valid for this case. The specific scenario here is an interplotated string with multiple parts. The steps are: 1. 2 threads attempt to get the children of an interpolated string operation at the same time. 2. Thread 1 gets the child for the first part of the string and caches it. 3. Thread 2 gets the child for the first part of the string and gets that same cached element. 4. Both threads attempt to get child 2. Neither hits the cache, so they get different nodes. 5. Both threads construct the array of interpolated string parts. 6. Thread 1 sets the parent of the interpolated string parts to be itself. 7. Thread 2 attempts to set the parent of the interpolated string parts to be itself. This returns early, because part 1 already has a parent, leaving part 2 with an unset parent. 8. Later, thread 2 asks for the parent of part 2. It is unset, violating the invariants, and we infinite loop. As an additional mitigation step, we also ensure that the process of constructing an interpolated string's inserts does not hit the cache. Since we never ask for an operation within a single expression, this will prevent 2 threads from seeing the same first element and differing subsequent elements.

Add test to validate non-repro issue.

…lements-in-naming-options only specify minimum heights and widths

Fix lambda completion inside `new()` arguments

…tTypedNew Add change signature support for target-typed new

)

* Classify function pointers correctly * Use a stable sort for classifications

…-mode-in-build always nuget restore in graph mode

Keep track of the trigger location for async completion

Show events completion inside NameOf

This test is hanging on test runs. Tracking issue dotnet#47720

Disable flaky optprof test

Exclude empty item from completion list

…s identifier. (dotnet#47715) Related to dotnet#47357.

[master] Update dependencies from dotnet/arcade

…named enum value. (dotnet#47693) * Use a distinct diagnostic ID when an exhaustiveness report uses an unnamed enum value. Fixes dotnet#47066

…otnet#47581)

Fixes VSO Watson [#1141257](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1141257) Regression was introduced in dotnet@3c37501#diff-464dab23fb56bf98bfcf831dd11f4288L228-L229. I forgot to add a break statement during some refactoring from PR feedback. Verified that added unit test hangs prior to the fix

Error list improvements

…t#47708)

…otnet#47756) Fixes dotnet#47614 See also dotnet/csharplang@2661a4b Bye for now!

* Remove langversion restriction for source generators.

…prevent them from being considered readonly by the language.

* upstream/master: (114 commits) Remove langversion restriction for source generators. (dotnet#47714) Adjust disambiguation rules for type pattern in a switch expression. (dotnet#47756) Delete decommissioned benchview tool scripts (dotnet#47752) Emit conversions between native integers and pointers directly (dotnet#47708) Typeless expressions should contribute nullability to lambda return (dotnet#47581) Use a distinct diagnostic ID when an exhaustiveness report uses an unnamed enum value. (dotnet#47693) [master] Update dependencies from dotnet/arcade (dotnet#46586) Change `Location` of record's primary constructor to point to record's identifier. (dotnet#47715) Add public API test for extended partial methods (dotnet#47727) Rename in CheckValidNullableMethodOverride (dotnet#47718) Update docs Add more doc comments Add comments and doc comments for ExternalErrorDiagnosticUpdateSource Add documentation remarks for syntax kinds (dotnet#43646) Disable TestCancellation (dotnet#47725) Classify function pointer punctuation (dotnet#47668) Disable flaky optprof test Handle NotNullIfNotNull in delegate creation and overrides (dotnet#47572) Adjust QuickInfo on record BaseType syntax (dotnet#47656) Don't exclude events for NameOf context ...

…duplicate-analyzer-references bugfix/msbuildworkspace duplicate analyzer references

Harden DiagnosticResultSerializer diagnostic reader part

Supply completions for negative regex categories as well.

…kspace-default-global-property-override msbuild workspace global property defaults can be overridden

…47536)

* Remove test caching layer The test caching layer is inactive today and unlikely to be revived in its current form. Test caching is much more likely to come at the Helix layer in the future. The cache code is just making the runner harder to maintain at this point hence removing it for now.

…ing property name (dotnet#47671)

…net#47733)

…ression analyzer Fixes dotnet#47288

The verbose logging option causes xUnit to output starting / finished markers for each of the tests that it is executing. This will help us track down the test that is hanging on Mac so frequently

Fix regression in SuppressMessageAttributeState.TargetSymbolResolver

…47777)

* Require partial method signatures to match * Revert changes * Fix tests * Fix tests * Avoid duplicate errors for tuples * Fix tests * Update numbering * Add distinct error for nullability mismatch * PR feedback * Another test * Fix test * Add warning wave warning * Update comments * Remove stale comments * PR feedback * Fix test * PR feedback * Update comments in CopyTypeCustomModifiers()

The Azure DevOps service is currently in the process of transitioning to a new Mac pool. The machines in the new Mac pool are observably slower than the ones in the old pool. This difference in speed appears to be the cause of our recent instability in the Mac jobs. Consider the following two jobs as a data point: - [Passed Build](https://dev.azure.com/dnceng/public/_build/results?buildId=818909&view=logs&j=1402d8c5-7e47-5bf4-467f-73e45e01bcce) - [Failed Build](https://dev.azure.com/dnceng/public/_build/results?buildId=819817&view=logs&j=1402d8c5-7e47-5bf4-467f-73e45e01bcce) At first I believed the source of the issue was a hang in the C# semantic tests. Pretty much all our OSX failures came when executing that test assembly. In a retent PR though I added a verbose log support and discovered it was failing on the test `AccessPropertyWithoutArguments`. That is a pretty basic test, no reason I can see that it would result in a Mac only hang bug. Decided to break down the runs into different sections and see how long it took each build to get to that section | Event | Passed Build Time | Failed Build Time | | --- | --- | --- | | Begin Real Build | 10 min | 12 min | | Begin Running Tests | 30 min | 54 min | | Begin C# semantic test | 39 min | 78 min | It seems very likely that the passed run ran on the old Mac pool and the failed run on the new Mac pool. The slow down lines up with what other repositories are seeing. As such I'm going to increase the timeout to account for this change. If my analysis is wrong and it's a real hang it should continue to reproduce after this change and I'll investigate further.

…tractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs Co-authored-by: David Wengier <david.wengier@microsoft.com>

* Allow record's `parameter_list` to be empty. Related to dotnet#47091 https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-08-24.md#base-calls-on-parameterless-records dotnet/csharplang#3900

…tractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs

…et#47734)

1. Make the error list build and live diagnostic de-duping cancellable: This ensures that repeated builds have fast error list refresh - currently, error list refresh for later builds will wait for all de-duping to complete for prior builds, just to throw away the computed results and re-refresh the error list. 2. Link error list refresh operations to workspace's disposal token 3. Eagerly initialize the saved project diagnostics from persistent storage after solution load to improve the error list refresh perf for the first build

Attach service to workspace disposal token.

Initial IDE test sweep for extended partial methods

Add tests for nullability with IDE0007 diagnostic

Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>

* Don't offer to generate properties or fields in the global error class * Cleanup

…rDiagnosticUpdateSource.cs

…into InitialLoadPerf

Move to .NET 5 Preview 8 SDK

If the file is already open, then this was causing us to trigger a reload prompt which we don't want.

This factory service was only being used to ensure there's a singleton across all workspaces, but that can be just as easily done by exporting it directly.

I passed the span to navigate to along to the service, and then never used it. Oops.

Source Generators always run now.

Some more error list performance improvements

Allow genearted local function parameter name to shadow variables

…opening-source-generated-files Fix issues with opening source generated files

Support category-based exclusions in user option for unnecessary supp…

Change hang to blocking

…otnet#47461) * Use MessagePack for ISB serialization * DocumentHighlighting service * Renamer, EncapsulateField, TupleToStruct services * SymbolFinder and FindUsages services * NavigateToSearch service * FindUsages, References fixes * AddImport service * SymbolSearchUpdate service * ExtensionMethodImportCompletion service * DependentTypeFinder service * GlobalNotificationDelivery service * CodeLensReferences service * Remove CodeAnalysis service * Remove unused code * Fix warnings. * Remove unused * Error reporting and logging * Update StreamJsonRpc to 2.6.86-alpha * Improve callback error handling. * Update Watson reporting * PR feedback * Fix tests * Fixes * Remove unused field * Rename shutdown service * Switch diagnostic serialization from ObjectReader/Writer serializer to MessagePack * Fix diagnostic reporting issue in ASP.NET apps

Update Extract Method to support top-level statements

)

Initialize FatalError handlers in VS and OOP

Update SyntaxNodeAnalysisContext.Compilation to not return null

See dotnet#44453

Improve comments for top-level statement insertion

…#47868)

Add tests for renaming records.

* Don't offer to fix naming on positional record parameters * Nullable enable * Fix formatting * Fix issue with nested constructors and parameters * Rebase and remove ThrowIfNull

…lt instance constructor for a record. (dotnet#47850) dotnet/csharplang#3913

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge 'upstream/master' into VarianceSafetyForStaticMembers #47888

Merge 'upstream/master' into VarianceSafetyForStaticMembers #47888

Commits on Sep 9, 2020

Commits on Sep 10, 2020

Commits on Sep 11, 2020

Commits on Sep 12, 2020

Commits on Sep 13, 2020

Commits on Sep 14, 2020

Commits on Sep 15, 2020

Commits on Sep 16, 2020

Commits on Sep 17, 2020

Commits on Sep 18, 2020

Commits on Sep 19, 2020

Commits on Sep 20, 2020

Commits on Sep 21, 2020