Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CA1822 in Visual Studio layer #50569

Merged
merged 28 commits into from
Jan 20, 2022
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e1e9fa4
Enable CA1822 in Visual Studio layer
Youssef1313 Jan 17, 2021
96b0f6d
Update .editorconfig
Youssef1313 Jan 17, 2021
3c4382c
Fix CA1822 - iteration 1
Youssef1313 Jan 18, 2021
012325b
Fix CA1822 - iteration 2
Youssef1313 Jan 18, 2021
bc63693
Fix CA1822 - iteration 3
Youssef1313 Jan 18, 2021
8bf9c81
Fix CA1822 - iteration 4
Youssef1313 Jan 18, 2021
376b670
Fix CA1822 - iteration 5
Youssef1313 Jan 18, 2021
ec7382b
Fix CA1822 - iteration 6
Youssef1313 Jan 18, 2021
f0ea7a3
Fix CA1822 - iteration 7
Youssef1313 Jan 18, 2021
99befa1
Fix CA1822 - iteration 8
Youssef1313 Jan 18, 2021
de87ad7
Fix CA1822 - iteration 9
Youssef1313 Jan 18, 2021
c768901
Fix CA1822 - iteration 10
Youssef1313 Jan 18, 2021
139a937
Fix CA1822 - iteration 11
Youssef1313 Jan 18, 2021
d1183c9
Fix CA1822 - iteration 12
Youssef1313 Jan 18, 2021
5120f0e
Fix CA1822 - iteration 13
Youssef1313 Jan 18, 2021
55a6db8
Fix CA1822 - iteration 14
Youssef1313 Jan 18, 2021
d476569
Fix CA1822 - iteration 15
Youssef1313 Jan 18, 2021
d09960c
Merge branch 'main' into patch-43
Youssef1313 Jan 14, 2022
2dddbbc
Remove redundant option
Youssef1313 Jan 14, 2022
2ce0f30
Resolve missing conflict
Youssef1313 Jan 14, 2022
e7ad72d
More fixes
Youssef1313 Jan 14, 2022
46d0e54
One more method
Youssef1313 Jan 15, 2022
fad6bfc
Update AbstractCodeCleanUpFixer.cs
Youssef1313 Jan 17, 2022
32d502a
Update CodeDefinitionWindow_InProc.cs
Youssef1313 Jan 18, 2022
a77a092
Update MoveStaticMembersViewModelTest.vb
Youssef1313 Jan 18, 2022
1dc81f8
Update InteractiveWindow_InProc.cs
Youssef1313 Jan 19, 2022
4cae7ce
Update MoveStaticMembersViewModelTest.vb
Youssef1313 Jan 19, 2022
defb193
Update AbstractPersistentStorageTests.cs
Youssef1313 Jan 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update .editorconfig
Youssef1313 authored Jan 17, 2021

Verified

This commit was signed with the committer’s verified signature.
swift-kim Swift Kim
commit 96b0f6dfbe6bb03d90827ef57f4cd153ffb508f3
1 change: 1 addition & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -272,4 +272,5 @@ csharp_style_var_elsewhere = true:warning
[src/{VisualStudio}/**/*.{cs,vb}]
# CA1822: Make member static
# There is a risk of accidentally breaking an internal API that partners rely on though IVT.
dotnet_diagnostic.CA1822.severity = warning
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks redundant as it's already specified above, but it's required due to #50577

dotnet_code_quality.CA1822.api_surface = private