-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CA1822 in Visual Studio layer #50569
Merged
+363
−362
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e1e9fa4
Enable CA1822 in Visual Studio layer
Youssef1313 96b0f6d
Update .editorconfig
Youssef1313 3c4382c
Fix CA1822 - iteration 1
Youssef1313 012325b
Fix CA1822 - iteration 2
Youssef1313 bc63693
Fix CA1822 - iteration 3
Youssef1313 8bf9c81
Fix CA1822 - iteration 4
Youssef1313 376b670
Fix CA1822 - iteration 5
Youssef1313 ec7382b
Fix CA1822 - iteration 6
Youssef1313 f0ea7a3
Fix CA1822 - iteration 7
Youssef1313 99befa1
Fix CA1822 - iteration 8
Youssef1313 de87ad7
Fix CA1822 - iteration 9
Youssef1313 c768901
Fix CA1822 - iteration 10
Youssef1313 139a937
Fix CA1822 - iteration 11
Youssef1313 d1183c9
Fix CA1822 - iteration 12
Youssef1313 5120f0e
Fix CA1822 - iteration 13
Youssef1313 55a6db8
Fix CA1822 - iteration 14
Youssef1313 d476569
Fix CA1822 - iteration 15
Youssef1313 d09960c
Merge branch 'main' into patch-43
Youssef1313 2dddbbc
Remove redundant option
Youssef1313 2ce0f30
Resolve missing conflict
Youssef1313 e7ad72d
More fixes
Youssef1313 46d0e54
One more method
Youssef1313 fad6bfc
Update AbstractCodeCleanUpFixer.cs
Youssef1313 32d502a
Update CodeDefinitionWindow_InProc.cs
Youssef1313 a77a092
Update MoveStaticMembersViewModelTest.vb
Youssef1313 1dc81f8
Update InteractiveWindow_InProc.cs
Youssef1313 4cae7ce
Update MoveStaticMembersViewModelTest.vb
Youssef1313 defb193
Update AbstractPersistentStorageTests.cs
Youssef1313 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update .editorconfig
- v4.2.0
- v4.2.0-4.22266.5
- v4.2.0-3.22151.16
- v4.2.0-1.22108.11
- Visual-Studio-2022-Version-17.13-Preview-1
- Visual-Studio-2022-Version-17.12.2
- Visual-Studio-2022-Version-17.12.1
- Visual-Studio-2022-Version-17.12
- Visual-Studio-2022-Version-17.12-Preview-5
- Visual-Studio-2022-Version-17.12-Preview-4
- Visual-Studio-2022-Version-17.12-Preview-3
- Visual-Studio-2022-Version-17.12-Preview-2.1
- Visual-Studio-2022-Version-17.12-Preview-2
- Visual-Studio-2022-Version-17.12-Preview-1
- Visual-Studio-2022-Version-17.11.6
- Visual-Studio-2022-Version-17.11.5
- Visual-Studio-2022-Version-17.11.4
- Visual-Studio-2022-Version-17.11.3
- Visual-Studio-2022-Version-17.11.2
- Visual-Studio-2022-Version-17.11.1
- Visual-Studio-2022-Version-17.11
- Visual-Studio-2022-Version-17.11-Preview-7
- Visual-Studio-2022-Version-17.11-Preview-6
- Visual-Studio-2022-Version-17.11-Preview-5
- Visual-Studio-2022-Version-17.11-Preview-4
- Visual-Studio-2022-Version-17.11-Preview-3
- Visual-Studio-2022-Version-17.11-Preview-2.1
- Visual-Studio-2022-Version-17.11-Preview-2
- Visual-Studio-2022-Version-17.11-Preview-1.1
- Visual-Studio-2022-Version-17.11-Preview-1
- Visual-Studio-2022-Version-17.10.9
- Visual-Studio-2022-Version-17.10.8
- Visual-Studio-2022-Version-17.10.7
- Visual-Studio-2022-Version-17.10.6
- Visual-Studio-2022-Version-17.10.5
- Visual-Studio-2022-Version-17.10.4
- Visual-Studio-2022-Version-17.10.3
- Visual-Studio-2022-Version-17.10.2
- Visual-Studio-2022-Version-17.10.1
- Visual-Studio-2022-Version-17.10
- Visual-Studio-2022-Version-17.10-Preview-7
- Visual-Studio-2022-Version-17.10-Preview-6
- Visual-Studio-2022-Version-17.10-Preview-5
- Visual-Studio-2022-Version-17.10-Preview-4
- Visual-Studio-2022-Version-17.10-Preview-3
- Visual-Studio-2022-Version-17.10-Preview-2
- Visual-Studio-2022-Version-17.10-Preview-1
- Visual-Studio-2022-Version-17.9.7
- Visual-Studio-2022-Version-17.9.6
- Visual-Studio-2022-Version-17.9.5
- Visual-Studio-2022-Version-17.9.4
- Visual-Studio-2022-Version-17.9.3
- Visual-Studio-2022-Version-17.9.2
- Visual-Studio-2022-Version-17.9.1
- Visual-Studio-2022-Version-17.9
- Visual-Studio-2022-Version-17.9-Preview-5
- Visual-Studio-2022-Version-17.9-Preview-4
- Visual-Studio-2022-Version-17.9-Preview-3
- Visual-Studio-2022-Version-17.9-Preview-2.1
- Visual-Studio-2022-Version-17.9-Preview-2
- Visual-Studio-2022-Version-17.9-Preview-1.1
- Visual-Studio-2022-Version-17.9-Preview-1
- Visual-Studio-2022-Version-17.8.16
- Visual-Studio-2022-Version-17.8.15
- Visual-Studio-2022-Version-17.8.14
- Visual-Studio-2022-Version-17.8.13
- Visual-Studio-2022-Version-17.8.12
- Visual-Studio-2022-Version-17.8.11
- Visual-Studio-2022-Version-17.8.10
- Visual-Studio-2022-Version-17.8.9
- Visual-Studio-2022-Version-17.8.8
- Visual-Studio-2022-Version-17.8.7
- Visual-Studio-2022-Version-17.8.6
- Visual-Studio-2022-Version-17.8.5
- Visual-Studio-2022-Version-17.8.4
- Visual-Studio-2022-Version-17.8.3
- Visual-Studio-2022-Version-17.8.2
- Visual-Studio-2022-Version-17.8.1
- Visual-Studio-2022-Version-17.8
- Visual-Studio-2022-Version-17.8-Preview-7
- Visual-Studio-2022-Version-17.8-Preview-6
- Visual-Studio-2022-Version-17.8-Preview-5
- Visual-Studio-2022-Version-17.8-Preview-4
- Visual-Studio-2022-Version-17.8-Preview-3
- Visual-Studio-2022-Version-17.8-Preview-2
- Visual-Studio-2022-Version-17.8-Preview-1
- Visual-Studio-2022-Version-17.7.6
- Visual-Studio-2022-Version-17.7.5
- Visual-Studio-2022-Version-17.7.4
- Visual-Studio-2022-Version-17.7.3
- Visual-Studio-2022-Version-17.7.2
- Visual-Studio-2022-Version-17.7.1
- Visual-Studio-2022-Version-17.7
- Visual-Studio-2022-Version-17.7-Preview-6
- Visual-Studio-2022-Version-17.7-Preview-5
- Visual-Studio-2022-Version-17.7-Preview-4
- Visual-Studio-2022-Version-17.7-Preview-3
- Visual-Studio-2022-Version-17.7-Preview-2
- Visual-Studio-2022-Version-17.7-Preview-1
- Visual-Studio-2022-Version-17.6.21
- Visual-Studio-2022-Version-17.6.20
- Visual-Studio-2022-Version-17.6.19
- Visual-Studio-2022-Version-17.6.18
- Visual-Studio-2022-Version-17.6.17
- Visual-Studio-2022-Version-17.6.16
- Visual-Studio-2022-Version-17.6.15
- Visual-Studio-2022-Version-17.6.14
- Visual-Studio-2022-Version-17.6.13
- Visual-Studio-2022-Version-17.6.12
- Visual-Studio-2022-Version-17.6.11
- Visual-Studio-2022-Version-17.6.10
- Visual-Studio-2022-Version-17.6.9
- Visual-Studio-2022-Version-17.6.8
- Visual-Studio-2022-Version-17.6.7
- Visual-Studio-2022-Version-17.6.6
- Visual-Studio-2022-Version-17.6.5
- Visual-Studio-2022-Version-17.6.4
- Visual-Studio-2022-Version-17.6.3
- Visual-Studio-2022-Version-17.6.2
- Visual-Studio-2022-Version-17.6.1
- Visual-Studio-2022-Version-17.6
- Visual-Studio-2022-Version-17.6-Preview-7
- Visual-Studio-2022-Version-17.6-Preview-6
- Visual-Studio-2022-Version-17.6-Preview-5
- Visual-Studio-2022-Version-17.6-Preview-4
- Visual-Studio-2022-Version-17.6-Preview-3
- Visual-Studio-2022-Version-17.6-Preview-2
- Visual-Studio-2022-Version-17.6-Preview-1
- Visual-Studio-2022-Version-17.5.5
- Visual-Studio-2022-Version-17.5.4
- Visual-Studio-2022-Version-17.5.3
- Visual-Studio-2022-Version-17.5.2
- Visual-Studio-2022-Version-17.5.1
- Visual-Studio-2022-Version-17.5
- Visual-Studio-2022-Version-17.5-Preview-6
- Visual-Studio-2022-Version-17.5-Preview-5
- Visual-Studio-2022-Version-17.5-Preview-4
- Visual-Studio-2022-Version-17.5-Preview-3
- Visual-Studio-2022-Version-17.5-Preview-2
- Visual-Studio-2022-Version-17.5-Preview-1
- Visual-Studio-2022-Version-17.4.4
- Visual-Studio-2022-Version-17.4.3
- Visual-Studio-2022-Version-17.4.2
- Visual-Studio-2022-Version-17.4.1
- Visual-Studio-2022-Version-17.4
- Visual-Studio-2022-Version-17.4-Preview-6
- Visual-Studio-2022-Version-17.4-Preview-5
- Visual-Studio-2022-Version-17.4-Preview-4
- Visual-Studio-2022-Version-17.4-Preview-3
- Visual-Studio-2022-Version-17.4-Preview-2.1
- Visual-Studio-2022-Version-17.4-Preview-2
- Visual-Studio-2022-Version-17.4-Preview-1
- Visual-Studio-2022-Version-17.3.6
- Visual-Studio-2022-Version-17.3.5
- Visual-Studio-2022-Version-17.3.4
- Visual-Studio-2022-Version-17.3.3
- Visual-Studio-2022-Version-17.3.2
- Visual-Studio-2022-Version-17.3.1
- Visual-Studio-2022-Version-17.3
- Visual-Studio-2022-Version-17.3-Preview-6
- Visual-Studio-2022-Version-17.3-Preview-5
- Visual-Studio-2022-Version-17.3-Preview-4
- Visual-Studio-2022-Version-17.3-Preview-3
- Visual-Studio-2022-Version-17.3-Preview-2
- Visual-Studio-2022-Version-17.3-Preview-1.1
- Visual-Studio-2022-Version-17.3-Preview-1
- Visual-Studio-2022-Version-17.2.12
- Visual-Studio-2022-Version-17.2.11
- Visual-Studio-2022-Version-17.2.10
- Visual-Studio-2022-Version-17.2.9
- Visual-Studio-2022-Version-17.2.8
- Visual-Studio-2022-Version-17.2.7
- Visual-Studio-2022-Version-17.2.6
- Visual-Studio-2022-Version-17.2.5
- Visual-Studio-2022-Version-17.2.4
- Visual-Studio-2022-Version-17.2.3
- Visual-Studio-2022-Version-17.2.2
- Visual-Studio-2022-Version-17.2.1
- Visual-Studio-2022-Version-17.2
- Visual-Studio-2022-Version-17.2-Preview-5
- Visual-Studio-2022-Version-17.2-Preview-4
- Visual-Studio-2022-Version-17.2-Preview-3
- Visual-Studio-2022-Version-17.2-Preview-2.1
- Visual-Studio-2022-Version-17.2-Preview-2
- Visual-Studio-2022-Version-17.2-Preview-1
- VSCode-CSharp-2.60.26
- VSCode-CSharp-2.59.14
- VSCode-CSharp-2.58.20
- VSCode-CSharp-2.57.28
- VSCode-CSharp-2.56.31
- VSCode-CSharp-2.56.29
- VSCode-CSharp-2.55.29
- VSCode-CSharp-2.55.28
- VSCode-CSharp-2.55.21
- VSCode-CSharp-2.54.20
- VSCode-CSharp-2.53.17
- VSCode-CSharp-2.52.24
- VSCode-CSharp-2.51.17
- VSCode-CSharp-2.50.27
- VSCode-CSharp-2.50.25
- VSCode-CSharp-2.49.25
- VSCode-CSharp-2.48.31
- VSCode-CSharp-2.46.32
- VSCode-CSharp-2.45.25
- VSCode-CSharp-2.45.20
- VSCode-CSharp-2.45.17
- VSCode-CSharp-2.44.19
- VSCode-CSharp-2.44.18
- VSCode-CSharp-2.43.16
- VSCode-CSharp-2.41.26
- VSCode-CSharp-2.39.29
- VSCode-CSharp-2.39.28
- VSCode-CSharp-2.38.16
- VSCode-CSharp-2.37.26
- VSCode-CSharp-2.36.19
- VSCode-CSharp-2.35.15
- VSCode-CSharp-2.34.12
- VSCode-CSharp-2.34.10
- VSCode-CSharp-2.33.17
- VSCode-CSharp-2.33.13
- VSCode-CSharp-2.32.14
- VSCode-CSharp-2.31.19
- VSCode-CSharp-2.31.16
- VSCode-CSharp-2.30.28
- VSCode-CSharp-2.30.24
- VSCode-CSharp-2.29.11
- VSCode-CSharp-2.28.11
- VSCode-CSharp-2.28.8
- VSCode-CSharp-2.26.13
- VSCode-CSharp-2.24.17
- VSCode-CSharp-2.23.15
- VSCode-CSharp-2.23.14
- VSCode-CSharp-2.23.2
- VSCode-CSharp-2.22.3
- VSCode-CSharp-2.22.2
- VSCode-CSharp-2.19.13
- VSCode-CSharp-2.18.16
- VSCode-CSharp-2.18.15
- VSCode-CSharp-2.17.7
- VSCode-CSharp-2.16.24
- VSCode-CSharp-2.15.30
- VSCode-CSharp-2.14.8
- VSCode-CSharp-2.13.10
- VSCode-CSharp-2.12.19
- VSCode-CSharp-2.12.4
- VSCode-CSharp-2.10.28
- VSCode-CSharp-2.9.20
- VSCode-CSharp-2.8.23
- VSCode-CSharp-2.7.25
- VSCode-CSharp-2.6.24
- VSCode-CSharp-2.5.30
- VSCode-CSharp-2.4.4
- VSCode-CSharp-2.4.2
- VSCode-CSharp-2.3.27
- VSCode-CSharp-2.1.2
- VSCode-CSharp-2.0.436
- VSCode-CSharp-2.0.212
- VSCode-CSharp-2.0.206
commit 96b0f6dfbe6bb03d90827ef57f4cd153ffb508f3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks redundant as it's already specified above, but it's required due to #50577