Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List patterns: parsing changes #53537

Closed
wants to merge 8 commits into from
Closed

List patterns: parsing changes #53537

wants to merge 8 commits into from

Conversation

alrz
Copy link
Member

@alrz alrz commented May 20, 2021 •
edited
Loading

In this PR:

  • Add langversion check in the parser
  • Relax slice subpattern to accept any pattern
  • Support length patterns in combinators

Test plan: #51289

@alrz alrz requested a review from a team as a code owner May 20, 2021 10:10
@alrz alrz requested a review from jcouv May 20, 2021 10:10
@alrz

This comment has been minimized.

Sign in to view
@jcouv jcouv added this to the C# 10 milestone May 20, 2021
@jcouv jcouv added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 20, 2021
@jcouv jcouv self-assigned this May 20, 2021
@jcouv jcouv mentioned this pull request Jun 3, 2021
Merged
jcouv
jcouv reviewed Jun 3, 2021
View reviewed changes
src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests_ListPatterns.cs
[Fact]
public void LengthPattern_17()
{
UsingExpression(@"c is not [<0]");
Copy link
Member

@jcouv jcouv Jun 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add full tests for those scenarios that now parse (verifying diagnostics and execution). #Closed

jcouv
jcouv reviewed Jun 3, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 3)

jcouv
jcouv approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 7)

@jcouv
Copy link
Member

jcouv commented Jun 3, 2021

@333fred @dotnet/roslyn-compiler for second review. Thanks

@jcouv jcouv requested review from 333fred and a team June 8, 2021 04:23
@jcouv
Copy link
Member

jcouv commented Jun 8, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@alrz alrz marked this pull request as draft June 22, 2021 12:54
@alrz
Copy link
Member Author

alrz commented Jun 24, 2021

Closing in favor of #54335

@alrz alrz closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred Awaiting requested review from 333fred

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. New Feature - List Patterns
Projects
None yet
Milestone
C# 10
Development

Successfully merging this pull request may close these issues.
2 participants
@alrz @jcouv