-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List patterns: parsing changes #53537
Conversation
This comment has been minimized.
This comment has been minimized.
[Fact] | ||
public void LengthPattern_17() | ||
{ | ||
UsingExpression(@"c is not [<0]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add full tests for those scenarios that now parse (verifying diagnostics and execution). #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with review pass (iteration 3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 7)
@333fred @dotnet/roslyn-compiler for second review. Thanks |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Closing in favor of #54335 |
In this PR:
Test plan: #51289