List patterns: change syntax to use square brackets #54335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-patterns-03 # Conflicts: # src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs
jcouv
reviewed
Jul 1, 2021
| case BoundKind.ListPattern: | ||
| { | ||
| return ((BoundListPattern)node).Variable as LocalSymbol; | ||
| } |
There was a problem hiding this comment.
Are the changes in iteration 34-37 (DataFlowOutWalker, DefiniteAssignemtn and VariablesDeclaredWalker) all part of fixing test ListPattern_Negated_01?
There was a problem hiding this comment.
I looked around for RecursivePattern to see what's missed. see comments below.
alrz
commented
Jul 2, 2021
Comment on lines
+130
to
+133
| case BoundKind.ListPattern: | ||
| { | ||
| return ((BoundListPattern)node).Variable as LocalSymbol; | ||
| } |
There was a problem hiding this comment.
📝 This is debug-only to assert data flow result. (currently disabled)
| @@ -1318,6 +1318,22 @@ protected virtual void AssignImpl(BoundNode node, BoundExpression value, bool is | |||
| break; | |||
| } | |||
|
|
|||
| case BoundKind.ListPattern: | |||
There was a problem hiding this comment.
📝 This is covered in ListPattern_Negated_01
| @@ -91,6 +91,14 @@ private void NoteDeclaredPatternVariables(BoundPattern pattern) | |||
| } | |||
| } | |||
| break; | |||
| case BoundListPattern list: | |||
alrz
force-pushed
the
list-patterns-syntax
branch
from
3e5c0ca
to
1fd452c
Compare
alrz
force-pushed
the
list-patterns-syntax
branch
from
1fd452c
to
3c2e686
Compare
333fred
reviewed
Jul 7, 2021
src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jul 7, 2021
333fred
reviewed
Jul 7, 2021
333fred
reviewed
Jul 7, 2021
333fred
reviewed
Jul 7, 2021
333fred
reviewed
Jul 7, 2021
333fred
reviewed
Jul 7, 2021
src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests_ListPatterns.cs
Show resolved
Hide resolved
333fred
reviewed
Jul 8, 2021
src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests_ListPatterns.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jul 8, 2021
src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests_ListPatterns.cs
Show resolved
Hide resolved
333fred
reviewed
Jul 8, 2021
src/Compilers/CSharp/Test/Syntax/Parsing/PatternParsingTests_ListPatterns.cs
Show resolved
Hide resolved
|
Done review pass (commit 38) |
That's what we've been doing since forever. |
alrz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://github.com/dotnet/csharplang/blob/main/proposals/list-patterns.md
Test plan: #51289