Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden enforcement on prototype marker #53886

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Jun 4, 2021

This first needs discussion with the IDE team.

Relates to #53888

@jcouv jcouv added the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Jun 4, 2021
@jcouv jcouv self-assigned this Jun 4, 2021
@jcouv jcouv removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Jun 8, 2021
@jcouv jcouv marked this pull request as ready for review June 8, 2021 18:23
@jcouv jcouv requested a review from a team as a code owner June 8, 2021 18:23
@jcouv
Copy link
Member Author

jcouv commented Jun 8, 2021

@sharwell @dotnet/roslyn-compiler for review.

jcouv and others added 2 commits June 8, 2021 12:45
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Jared Parsons <jaredpparsons@gmail.com>
@jcouv
Copy link
Member Author

jcouv commented Jun 8, 2021

@jaredpar I may have to exclude the eng folder or at least the test-build-correctness.ps1 file, as it contains the word "PROTOTYPE" ;-)

@jcouv jcouv requested a review from sharwell June 9, 2021 07:03
@jcouv
Copy link
Member Author

jcouv commented Jun 9, 2021

From discussion with @sharwell I'll try and update this PR to use git grep, something like git grep -I -F PROTOTYPE -- ':(exclude)eng/test-build-correctness.ps1' ':(exclude)*.md'
Thanks for the tip

@jcouv jcouv merged commit 6543c70 into dotnet:main Jun 10, 2021
@ghost ghost added this to the Next milestone Jun 10, 2021
@jcouv jcouv deleted the check-prototype branch June 10, 2021 17:23
333fred added a commit that referenced this pull request Jun 14, 2021
…ures/interpolated-string

* upstream/main: (95 commits)
  Update official build number in separate job
  Update Language Feature Status.md (#54015)
  Remove IRazorDocumentOptionsService inheritance interface (#54047)
  Fix comment
  Simplify
  Do not create a cache field for lambda if it depends on caller's type argument (#44939)
  Documentation
  Documentation
  Documentation
  Update test impls
  Just pass null
  Pull diagnostics should just request from the doc, not the whole project.
  Add test plan for file-scoped namespace (#54003)
  Add source build to official build
  Improved nullable 'is' analysis (#53311)
  Multi session service (#53762)
  Resolve Versions.props conflicts
  Revert "Revert "Require partial method signatures to match" (47576) (#47879)" (#53352)
  Broaden enforcement on prototype marker (#53886)
  Update Language Feature Status.md (#53926)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants