Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden enforcement on prototype marker #53886

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Broaden enforcement on prototype marker #53886

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0404361
Broaden enforcement of PROTOTYPE check
jcouv Jun 8, 2021
192f15c
Update eng/test-build-correctness.ps1
jcouv Jun 8, 2021
4c35d8e
Update eng/test-build-correctness.ps1
jcouv Jun 8, 2021
f1ac075
Search all files except a few extensions
jcouv Jun 8, 2021
718c8d8
Exclude test-build-correctness.ps1
jcouv Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/test-build-correctness.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ try {
# Verify no PROTOTYPE marker left in main
if ($env:SYSTEM_PULLREQUEST_TARGETBRANCH -eq "main") {
Write-Host "Checking no PROTOTYPE markers in compiler source"
jcouv marked this conversation as resolved.
Show resolved Hide resolved
$prototypes = Get-ChildItem -Path src/Compilers/*.cs, src/Compilers/*.vb,src/Compilers/*.xml -Recurse | Select-String -Pattern 'PROTOTYPE' -CaseSensitive -SimpleMatch
$prototypes = Get-ChildItem -Path src/*.cs, src/*.vb, src/*.xml -Recurse | Select-String -Pattern 'PROTOTYPE' -CaseSensitive -SimpleMatch
jcouv marked this conversation as resolved.
Show resolved Hide resolved
if ($prototypes) {
Write-Host "Found PROTOTYPE markers in compiler source:"
jcouv marked this conversation as resolved.
Show resolved Hide resolved
Write-Host $prototypes
Expand Down