Address remaining prototype comments #53929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
requested changes
Jun 8, 2021
| state = _comparer.Equals(builder.GetLastEntries()[0], entry) ? EntryState.Cached : EntryState.Modified; | ||
| } | ||
|
|
||
| builder.AddEntry(entry, state); |
There was a problem hiding this comment.
Need to add tests for this change / commit (making Join comparable)
src/Compilers/Core/Portable/SourceGeneration/Nodes/NodeStateTable.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jun 8, 2021
src/Compilers/Core/Portable/SourceGeneration/AdditionalSourcesCollection.cs
Show resolved
Hide resolved
cston
reviewed
Jun 8, 2021
src/Compilers/Core/Portable/SourceGeneration/Nodes/DriverStateTable.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jun 8, 2021
3 tasks
cston
reviewed
Jun 8, 2021
|
|
||
| var exception = Assert.Throws<ArgumentException>(() => asc.Add("file5.cs", SourceText.From("", encoding: null))); | ||
|
|
||
| // check the exception contains the excpected |
jaredpar
approved these changes
Jun 8, 2021
cston
approved these changes
Jun 8, 2021
cston
reviewed
Jun 8, 2021
| var source = @" | ||
| class C { } | ||
| "; | ||
| var parseOptions = TestOptions.Regular.WithLanguageVersion(LanguageVersion.Preview); |
cston
reviewed
Jun 8, 2021
| Assert.Equal(texts[0], calledFor[0].Item2.Single()); | ||
|
|
||
| // edit the additional texts, and verify that the output was *not* called again on the next run | ||
| driver = driver.RemoveAdditionalTexts(texts.ToImmutableArray()); |
There was a problem hiding this comment.
Create is just a helper method, and calls ToImmutableArray() under the hood. We should probably expose a Create overload that takes an ImmutableArray directly, but this is the same as V1.
cston
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issue remaining with the feature, may be easiest to go commit by commit.
Note there is still one remaining comment here: https://github.com/chsienki/roslyn/blob/2a2d444eaa27a53cf84011645cbc729b5a9adc5d/src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs#L459 which is a skipped test. We should decide if the behavior difference is acceptable or not.