Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address remaining prototype comments #53929

Merged
merged 14 commits into from
Jun 8, 2021
Merged

Address remaining prototype comments #53929

merged 14 commits into from
Jun 8, 2021

Commits on May 26, 2021

  1. Address some proto comments

    @chsienki
    chsienki committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a860e6f View commit details
    Browse the repository at this point in the history

  2. Rename IsCompacted/Compact -> Cached/AsCached

    @chsienki
    chsienki committed May 26, 2021
    Configuration menu
    Copy the full SHA
    23f8edd View commit details
    Browse the repository at this point in the history

  3. Allow a join node to support comparison

    @chsienki
    chsienki committed May 26, 2021
    Configuration menu
    Copy the full SHA
    86da615 View commit details
    Browse the repository at this point in the history

  4. Clean up modify for join node

    @chsienki
    chsienki committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a8aaeb0 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Clear out the state table state when there are no drivers

    @chsienki
    chsienki committed May 27, 2021
    Configuration menu
    Copy the full SHA
    fc8e625 View commit details
    Browse the repository at this point in the history

  2. Add hintName to exceptions

    @chsienki
    chsienki committed May 27, 2021
    Configuration menu
    Copy the full SHA
    4e15e74 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Remove IsFaulted and just handle syntax node specially

    @chsienki
    chsienki committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3cf12ae View commit details
    Browse the repository at this point in the history

  2. Address remaining prototype comments

    @chsienki
    chsienki committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    2a2d444 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Update tests to validate exception messages

    @chsienki
    chsienki committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    6152720 View commit details
    Browse the repository at this point in the history

  2. Fix missing else

    @chsienki
    chsienki committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d72fc69 View commit details
    Browse the repository at this point in the history

  3. Remove assert

    @chsienki
    chsienki committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4cdf3ae View commit details
    Browse the repository at this point in the history

  4. Test for join comparer

    @chsienki
    chsienki committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    25aa6c4 View commit details
    Browse the repository at this point in the history

  5. Typo

    @chsienki
    chsienki committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    a24388b View commit details
    Browse the repository at this point in the history

  6. Use TestOptions.RegularPreview

    @chsienki
    chsienki committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2ab79a5 View commit details
    Browse the repository at this point in the history