Update to Microsoft.CodeAnalysis.Testing 1.1.0-beta1.21322.2 #54302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
update-test-libs
branch
from
5a5edf1
to
83ac575
Compare
This is a convenience method for the equivalent of AddRange inside a collection initializer.
| else if (_analyzerConfigIndex is { } index) | ||
| { | ||
| _analyzerConfigIndex = null; | ||
| TestState.AnalyzerConfigFiles.RemoveAt(index); |
There was a problem hiding this comment.
i don't quite get what's going o nhere.
There was a problem hiding this comment.
The code fix tests got more strict, and now verify the before/after contents of .editorconfig. It's expecting the inputs to be declared in TestState.AnalyzerConfigFiles, but we can't do that since the content is generated dynamically. This code add/updates/removes the AnalyzerConfigFiles entry generated for Options.
| TestState.AnalyzerConfigFiles.RemoveAt(index); | ||
| } | ||
|
|
||
| await base.RunImplAsync(cancellationToken); |
There was a problem hiding this comment.
pity about all the duplication in these 4 areas.
There was a problem hiding this comment.
Yeah it's a bit of duplication. :\
There was a problem hiding this comment.
Trying something different...
...orFeatures/DiagnosticsTestUtilities/CodeActions/VisualBasicCodeRefactoringVerifier`1+Test.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jun 22, 2021
sharwell
force-pushed
the
update-test-libs
branch
from
37fe6c1
to
ac79a16
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit-by-commit recommended.
OptionsCollection.Add(OptionsCollection)sinceAddRangecannot be used in a collection initializer