Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main to main-vs-deps #54405

Merged
28 commits merged into from
Jun 27, 2021
Merged

Merge main to main-vs-deps #54405

28 commits merged into from
Jun 27, 2021

Commits on Jun 17, 2021

  1. Add new navigation pattern for Value Tracking

    @ryzngard
    ryzngard committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    1e33c08 View commit details
    Browse the repository at this point in the history

  2. Update src/VisualStudio/Core/Def/ValueTracking/TreeItemViewModel.cs 

    Co-authored-by: David Wengier <david.wengier@microsoft.com>
    @ryzngard @davidwengier
    ryzngard and davidwengier authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    87b57a5 View commit details
    Browse the repository at this point in the history

  3. Fix double click handler to preview. Move collection changed into own… 

    … method
    @ryzngard
    ryzngard committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    57cdb28 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Merge branch 'main' into feature/value_tracking_tree_navigation

    @ryzngard
    ryzngard committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    897d2c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. PR feedback. Go back to more navigation for initial release

    @ryzngard
    ryzngard committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    07601c1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/value_tracking_tree_navigation' of https://www.… 

    …github.com/ryzngard/roslyn into feature/value_tracking_tree_navigation
    @ryzngard
    ryzngard committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    53e848b View commit details
    Browse the repository at this point in the history

  3. Correctness...

    @ryzngard
    ryzngard committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    72c771a View commit details
    Browse the repository at this point in the history

  4. Sure, why not

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4a453c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Fast progression search.

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7cdaaad View commit details
    Browse the repository at this point in the history

  2. Update tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    cdbede7 View commit details
    Browse the repository at this point in the history

  3. Fixup tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    d105390 View commit details
    Browse the repository at this point in the history

  4. Report as we get results

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    65cefe1 View commit details
    Browse the repository at this point in the history

  5. Multple matches

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    21dd1a3 View commit details
    Browse the repository at this point in the history

  6. Split tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    987a5c3 View commit details
    Browse the repository at this point in the history

  7. not roaming

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    c93d06a View commit details
    Browse the repository at this point in the history

  8. vert

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    380572b View commit details
    Browse the repository at this point in the history

  9. Simplify glyph computation

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f684737 View commit details
    Browse the repository at this point in the history

  10. Remove unused property

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f6ff0f7 View commit details
    Browse the repository at this point in the history

  11. Cleanup

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    c7a45ed View commit details
    Browse the repository at this point in the history

  12. Finer grained cancellation

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    a8c3567 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #54382 from CyrusNajmabadi/progression 

    Speed up progression searches by using the navigate-to index
    @CyrusNajmabadi
    CyrusNajmabadi authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    eb02555 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'upstream/main' into progrssionCancellation

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b3e26b0 View commit details
    Browse the repository at this point in the history

  15. remove disable

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    e60d86a View commit details
    Browse the repository at this point in the history

  16. Merge pull request #54163 from ryzngard/feature/value_tracking_tree_n… 

    …avigation

Value tracking originally used the standard WPF navigation pattern. This would also navigate to the source line based on selection.

This improves the design by manually handling keyboard navigation for most cases. By default, if an item is selected it no longer navigates to source. There are conditions where this is different:

| Shortcut | Expand Behavior | Navigates To Source | Previous or Next |
| --------- | ---------------- | ---------------------- | --------------------- |
| Arrow Down | False | True| Next |
| Arrow Up | False | True| Next |
| Arrow Left | Collapse Only | False | Neither |
| Arrow Right | Expand Only | False | Neither |
| Space | Toggle | False | Neither |
| Enter | False | True | Neither |
| F8 | Expand Only | True | Next |
| Shift + F8 | False | True | Previous |
| Click | False | True| Neither |
| Double Click | False | True | Neither |
    @ryzngard
    ryzngard authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    ee996f2 View commit details
    Browse the repository at this point in the history

  17. pass tokens

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    9212aee View commit details
    Browse the repository at this point in the history

  18. pass tokens

    @CyrusNajmabadi
    CyrusNajmabadi committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    39dd19d View commit details
    Browse the repository at this point in the history

  19. Add IVT for UnitTestingHostReloadService (#54366) 

    Co-authored-by: David Wengier <david.wengier@microsoft.com>
    @vritant24 @davidwengier
    vritant24 and davidwengier authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2384855 View commit details
    Browse the repository at this point in the history

  20. Merge pull request #54402 from CyrusNajmabadi/progrssionCancellation 

    Thread cancellation tokens through progression in more places.
    @CyrusNajmabadi
    CyrusNajmabadi authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    da30d23 View commit details
    Browse the repository at this point in the history