Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.0 to release/dev17.0-vs-deps #54683

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.0 into release/dev17.0-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/release/dev17.0-to-release/dev17.0-vs-deps
git reset --hard upstream/release/dev17.0-vs-deps
git merge upstream/release/dev17.0
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.0-to-release/dev17.0-vs-deps --force

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

Revert "Ensure we don't try and build an empty table when modifying entries"
@dotnet-bot dotnet-bot requested a review from a team as a code owner July 8, 2021 08:59
@allisonchou
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@allisonchou
Copy link
Contributor

@JoeRobich Would it be possible to force merge this PR? The checks passed but for some reason the roslyn-integration-CI is stuck on "Waiting for status to be reported". I tried re-running the tests via azp run but it still seems to be stuck.

@JoeRobich JoeRobich disabled auto-merge July 8, 2021 16:39
@JoeRobich
Copy link
Member

Merging to unblock insertion.

@JoeRobich JoeRobich merged commit 0bc8176 into release/dev17.0-vs-deps Jul 8, 2021
@allisonchou allisonchou deleted the merges/release/dev17.0-to-release/dev17.0-vs-deps branch July 8, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants