Use bulk unsubscribe operations in FileChangeWatcher #55890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sharwell
changed the base branch from
main-vs-deps
to
release/dev17.1-preview1-vs-deps
sharwell
changed the base branch from
release/dev17.1-preview1-vs-deps
to
main-vs-deps
ryzngard
approved these changes
Aug 25, 2021
src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionResolveHandler.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/ProjectSystem/FileChangeWatcher.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Aug 26, 2021
sharwell
force-pushed
the
bulk-unsubscribe
branch
from
a8e9c90 to
7decaee
Compare
jasonmalinowski
approved these changes
Aug 30, 2021
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Signing off on the bulk unsubscribe work; I would like to see the Newtonsoft.Json change broken out as a separate PR I think so we can just vet whether those are correct. Some of those might be pointing out actual bugs we should be fixing (or at least providing better user-visible messages). I also admit I'm finding Assumes.Present strange to see in non-VS code.
src/VisualStudio/Core/Def/Implementation/ProjectSystem/FileChangeWatcher.cs
Show resolved
Hide resolved
sharwell
force-pushed
the
bulk-unsubscribe
branch
from
7decaee to
d2e6529
Compare
sharwell
force-pushed
the
bulk-unsubscribe
branch
from
d2e6529 to
127b538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #55855