Skip to content

Use bulk unsubscribe operations in FileChangeWatcher #55890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Use bulk unsubscribe operations in FileChangeWatcher #55890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/VisualStudio/Core/Def/Implementation/ProjectSystem/FileChangeWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,20 +417,12 @@ public async ValueTask ApplyAsync(IVsAsyncFileChangeEx service, CancellationToke

case Kind.UnwatchDirectories:
Contract.ThrowIfFalse(_cookies is not null);
foreach (var unwatchCookie in _cookies)
{
await service.UnadviseDirChangeAsync(unwatchCookie, cancellationToken).ConfigureAwait(false);
}

await service.UnadviseDirChangesAsync(_cookies, cancellationToken).ConfigureAwait(false);
return;

case Kind.UnwatchFiles:
Contract.ThrowIfFalse(_tokens is not null);
foreach (var token in _tokens)
{
await service.UnadviseFileChangeAsync(token.Cookie!.Value, cancellationToken).ConfigureAwait(false);
}

await service.UnadviseFileChangesAsync(_tokens.Select(token => token.Cookie!.Value).ToArray(), cancellationToken).ConfigureAwait(false);
return;

default:
Expand Down