More options refactoring

[tmat]

Read global options (options not serialized to the solution snapshot) directly using IGlobalOptionService rather then via Solution.Options or Workspace.Options.

[tmat]

@dibarbet @dotnet/roslyn-ide PTAL

[dibarbet]

had a general overall question when reading through this PR - How do I know when an option should be retrieved (or set) from the IGlobalOptionService vs. the solution options? For example, why are the NavigationOptions solution options and not global ones?

Clearly feature flags are generally global options. Is everything else a solution option? And will I get an error if I try and use a solution option to query the IGlobalOptionService?

Otherwise PR looks good

[tmat]

had a general overall question when reading through this PR - How do I know when an option should be retrieved (or set) from the IGlobalOptionService vs. the solution options? For example, why are the NavigationOptions solution options and not global ones?

Clearly feature flags are generally global options. Is everything else a solution option? And will I get an error if I try and use a solution option to query the IGlobalOptionService?

Otherwise PR looks good

That's currently a bit of a problem to see. The solution option setter serializes options whose provider is defined in Workspaces or Features layer. Those options are solution options - they are serialized over to OOP. Other options are global options, which are not available in OOP.

I'm thinking of introducing marker interfaces IGlobalOptionProvider/ISolutionOptionProvider to make it more explicit.

Hopefully, once I'm done with the refactorings it will be clearer. Currently the system is very complex.

[dibarbet]

I'm thinking of introducing marker interfaces IGlobalOptionProvider/ISolutionOptionProvider to make it more explicit.

I think that would be good. Is it also possible to mark an Option or Option2 as being global or solution based, and get a compile error if I try and retrieve a global option from the solution for example?

[tmat]

I think that would be good. Is it also possible to mark an Option or Option2 as being global or solution based, and get a compile error if I try and retrieve a global option from the solution for example?

Unfortunately, not as it is designed today. Options do not know which provider owns them. In theory they can be owned by multiple.