-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Move VS lsp client implementation to EditorFeatures for VSMac #56051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dibarbet
merged 6 commits into
dotnet:release/dev17.1-preview1
from
dibarbet:lsp_editor_features
Sep 10, 2021
Merged
Move VS lsp client implementation to EditorFeatures for VSMac #56051
dibarbet
merged 6 commits into
dotnet:release/dev17.1-preview1
from
dibarbet:lsp_editor_features
Sep 10, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tmat
reviewed
Sep 1, 2021
src/VisualStudio/Core/Def/Implementation/LanguageClient/AbstractInProcLanguageClient.cs
Outdated
Show resolved
Hide resolved
85406c0 to
8f1b62c
Compare
571b3d2 to
c9b2877
Compare
5380c11 to
9668b4b
Compare
jasonmalinowski
approved these changes
Sep 8, 2021
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but a few requests for TODO comments or equivalent. There's also some types that got moved to EditorFeatures that still have "VisualStudio" prefixes for no clear reason and can probably be renamed.
src/Workspaces/CoreTestUtilities/Microsoft.CodeAnalysis.Workspaces.Test.Utilities.csproj
Show resolved
Hide resolved
src/Features/Lsif/Generator/Microsoft.CodeAnalysis.LanguageServerIndexFormat.Generator.csproj
Show resolved
Hide resolved
...orFeatures/Core/Implementation/LanguageServer/VisualStudioLspWorkspaceRegistrationService.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/Implementation/LanguageServer/VisualStudioInProcLanguageServer.cs
Show resolved
Hide resolved
...ures/Core/Implementation/LanguageServer/VisualStudioLspWorkspaceRegistrationEventListener.cs
Outdated
Show resolved
Hide resolved
e800069 to
e519d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things
Removes the VisualStudioWorkspace import from ILanguageClient implementations in favor of a service that retrieves the HostWorkspaceServices (allows VSMac to provide their own set).Resolved by More options refactoring #56089 to use the global options service in all cases where we previously accessed the workspace.TODO verify on helix