List-patterns: mitigate break with Length property patterns #56721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrz
reviewed
Oct 1, 2021
| @@ -806,7 +806,7 @@ public static void Multiple(bool includeStackTrace, params Action[] assertions) | |||
| return; | |||
|
|
|||
| var stringBuilder = new StringBuilder($"{exceptions.Count} out of {assertions.Length} assertions failed."); | |||
| foreach (var (index, ex) in exceptions) | |||
| foreach (var (index, ex) in exceptions.OrderBy(e => e.Index)) | |||
There was a problem hiding this comment.
If we need to do this (why?) there's no need to run assertions in the reverse order above.
Comment on lines
+350
to
+352
| case ErrorCode.WRN_SwitchArmSubsumedIfNonNegativeLength: | ||
| case ErrorCode.WRN_IsPatternAlwaysIfNonNegativeLength: | ||
| case ErrorCode.WRN_IsPatternImpossibleIfNonNegativeLength: |
There was a problem hiding this comment.
Shouldn't these be reported for level 7 only?
There was a problem hiding this comment.
LDM discussed a regular warning (as a documented breaking change), not a warning wave warning.
|
From discussion with LDM today (10/13/2021) we're leaning towards taking the break after all. We'll revisit if some real-world types hit this issue in some serious way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language design issue: dotnet/csharplang#5226
Relates to test plan #51289
TODO: