Document break for negative Length tests #57149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
commented
Oct 14, 2021
| "; | ||
| var comp = CreateCompilation(src); | ||
| comp.VerifyDiagnostics( | ||
| // (5,7): warning CS8509: The switch expression does not handle all possible values of its input type (it is not exhaustive). For example, the pattern 'not null' is not covered. |
There was a problem hiding this comment.
📝 This diagnostic may seem odd, but I think it's correct. The switch is null => ..., <impossible> => ... so we indeed didn't handle not null.
RikkiGibson
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also picked a few tests from closed PR #56721
The second commit uses file-scoped namespaces (so mostly indent change). Use
?w=1in github URL to ignore whitespaces in diff, like so.Relates to test plan #51289
FYI @alrz