-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Emit compiler version to Windows PDB #56759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Probably needs some test |
Definitely, but can't really test until Microsoft.DiaSymReader.Native.*.dll is available. |
|
When will it be available? |
|
@tmat did you intend to say on .NET Framework it depends on the globally installed version, or is it really the case that the .NET Core version depends on the full framework copy of diasymreader? |
No, nothing depends on globally installed version. |
jcouv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 5). From discussion with Jared I understand this is time sensitive and was tested manually. Please open a follow-up issue to add tests once the package is available.
|
Don't forget to retarget this PR to the 17.0 branch as needed. |
3141981 to
93fbdfb
Compare
93fbdfb to
8a5300d
Compare
Uses new SymReader API to write compiler version info to Windows PDB.
No op if the SymReader does not implement the API.
The new API will be added to Microsoft.DiaSymReader.Native.*.dll (not available yet). On .NET Core the library is loaded from the CLR runtime so this will require the runtime to be updated first before we can test on Core.
Similar change in Crossgen: dotnet/runtime#59686
The compiler emits the following Windows PDB S_COMPILE3 record: